Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember file usage default to node_modules/.embroider/rewritten_app copy of component even if excluded #49

Closed
emattias opened this issue Nov 4, 2024 · 4 comments

Comments

@emattias
Copy link

emattias commented Nov 4, 2024

When I press to go to a component that uses the currently active component/template/etc

CleanShot 2024-11-04 at 16 38 44@2x

It includes the copy of the component/template/etc that is created in node_modules/.embroider/rewritten_app/ folder.

And it does this even when I have completely excluded node_modules/.embroider from vscode.

Can an exclude option be added of make the extension follow the vscode exclude setting?

@lifeart
Copy link
Owner

lifeart commented Nov 7, 2024

Hi @emattias! Thank you for report!
Im my understanding this change should fix behaviour: ember-tooling/ember-language-server#413
I will let you know once we publish new version of extension

@lifeart
Copy link
Owner

lifeart commented Nov 7, 2024

@emattias EmberTooling.vscode-ember v3.0.58 published
Let me know if issue still appear.
Actual repo: https://github.com/ember-tooling/vscode-ember/

@lifeart lifeart closed this as completed Nov 7, 2024
@emattias
Copy link
Author

emattias commented Nov 8, 2024

@lifeart So which extension should we use? Stable Ember Language Server or Ember Language Server? 😅

@lifeart
Copy link
Owner

lifeart commented Nov 8, 2024

@emattias now you may count https://marketplace.visualstudio.com/items?itemName=EmberTooling.vscode-ember as upstream.

https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-ember-unstable - will be around for some time (but may be disabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants