You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following code in the KnxReceiverTunneling.cs is supposed to make sure you do not duplicate telegrams that were processed already:
lock (_rxSequenceNumberLock)
{
if (sequenceNumber <= _rxSequenceNumber)
process = false;
_rxSequenceNumber = sequenceNumber;
}
However sequenceNumber is a byte value and it gets reset after reaching 255. This results in loosing every 256th telegram. I'd rather have duplicate telegrams than missing some. Does it make sense to remove the 'process' variable and the associated logic?
The text was updated successfully, but these errors were encountered:
The following code in the KnxReceiverTunneling.cs is supposed to make sure you do not duplicate telegrams that were processed already:
However sequenceNumber is a byte value and it gets reset after reaching 255. This results in loosing every 256th telegram. I'd rather have duplicate telegrams than missing some. Does it make sense to remove the 'process' variable and the associated logic?
The text was updated successfully, but these errors were encountered: