Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing telegrams in Tunnelling #53

Open
akellai opened this issue Jan 30, 2019 · 0 comments
Open

missing telegrams in Tunnelling #53

akellai opened this issue Jan 30, 2019 · 0 comments

Comments

@akellai
Copy link

akellai commented Jan 30, 2019

The following code in the KnxReceiverTunneling.cs is supposed to make sure you do not duplicate telegrams that were processed already:

        lock (_rxSequenceNumberLock)
        {
            if (sequenceNumber <= _rxSequenceNumber)
                process = false;

            _rxSequenceNumber = sequenceNumber;
        }

However sequenceNumber is a byte value and it gets reset after reaching 255. This results in loosing every 256th telegram. I'd rather have duplicate telegrams than missing some. Does it make sense to remove the 'process' variable and the associated logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant