-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a script to check for new files #121
Comments
Partial improvement made in this commit b80fefc Hopefully, it lists the changed (including new and removed) files in the PR and commit message. |
Had a think about this today. I don't think it's realistic for us to automatically update the CMake configuration since there's no way for us to know what sub-library ( I want to use a regex to parse the Does that seem ok to you? |
Very good point, and I agree with both statements
A regex would work but there's also a native way to filter for added, modified, and deleted files that I just learned about recently: git diff --diff-filter=M and we could probably run it 3 times for each of Moreover, I think there are some additional improvements to be made for the sleighspec directory: We should do one (or combination) of the following (or some other equivalent)
|
When new files are added to Sleigh, sometimes our weekly sync with Ghidra continues working fine and we don't notice. This leads us to having missing headers which we have to fix later down the track (#107).
We should write a script as part of our weekly sync that identifies new files and either adds them to the PR or fails loudly so we can manually fix it.
The text was updated successfully, but these errors were encountered: