You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Had a quick look at this today but I think it'll require a bit more thought. Even in the normal case where we've provided sufficient instruction data, Sleigh calls loadFill with a size argument past the end of the image buffer.
I suspect that's not a bug on our end but rather that's how Sleigh expects LoadImage implementations to work since the implementations that I can spot in Ghidra seem to have this zero-fill behaviour.
We should probably check the length of the lifted instruction to make sure we arent reading bytes from the 0 fill
sleigh/extra-tools/sleigh-lift/src/main.cpp
Line 72 in b3669ea
ie.
./extra-tools/sleigh-lift/sleigh-lift disassemble ARM7_le.sla 002C -p ./specfiles
should not print:0x00000000: andeq r2,r0,r0, lsl #0x18
and should probably present an error like "not enough bytes"
For users who are not aware of how fills work on the backend/context registers etc the current behavior is non-obvious
The text was updated successfully, but these errors were encountered: