Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update does not update if required fields are not set #811

Open
jewzaam opened this issue Sep 6, 2017 · 1 comment
Open

Update does not update if required fields are not set #811

jewzaam opened this issue Sep 6, 2017 · 1 comment

Comments

@jewzaam
Copy link
Member

jewzaam commented Sep 6, 2017

Tried updating a document today and it didn't fail. Match count is 0 but updated count is 1. No error in the response. Went to logs and saw an ERROR for my update request saying a required field was not set. Two issues.

  1. this shouldn't stop the update probably
  2. if it does stop the update, it should propagate up to the caller!
@paterczm
Copy link
Contributor

paterczm commented Oct 2, 2017 •
edited
Loading

  1. Introduce a concept of a default value. Can use existing value generator api to handle it. That's in addition to sending an error to the caller if there is no default and required value was not provided.

@paterczm paterczm mentioned this issue Oct 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jewzaam @paterczm