Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombie recovery error error matching keys to script: address: must be a bech32 P2WPKH or P2WSH address #133

Closed
hsjoberg opened this issue May 6, 2024 · 11 comments · Fixed by #141

Comments

@hsjoberg
Copy link

hsjoberg commented May 6, 2024

Hi, I'm getting the following error when trying to do a zombie recovery.

error matching keys to script: address: must be a bech32 P2WPKH or P2WSH address

Does zombie channel recovery support Taproot channels? This is a private taproot channel.

Cheers
Hampus

@hsjoberg hsjoberg closed this as completed May 6, 2024
@hsjoberg hsjoberg reopened this May 6, 2024
@hsjoberg hsjoberg changed the title Zombie recovery error error matching keys to script: unable to decode address Zombie recovery error error matching keys to script: address: must be a bech32 P2WPKH or P2WSH address May 6, 2024
@guggero
Copy link
Member

guggero commented May 6, 2024

No, Taproot Channels are currently not supported by chantools (or at least not in the zombie recovery flow).

@hsjoberg
Copy link
Author

hsjoberg commented May 6, 2024

I see. Thank you for your reply

@Darth-Coin
Copy link

@guggero please can we have more "love" for this chantools update?
There are a growing number of users of simple taproot channels that could end up in such situation. I think this is an important update for chantools.
Thanks

@guggero
Copy link
Member

guggero commented Jun 15, 2024

@Darth-Coin see #141.
That wasn't easy at all...
I had to:

Took me about 2 days of my precious spare time. So I hope you show some "love" back by testing, reviewing, whatever.

How do your users (@hsjoberg, @kaloudis) even get into this situation? Because the normal zombie matching process of node-recovery.com can't be it, since Simple Taproot channels are private only and will never be known by the wider graph.
So IMO there need to be quite a few warning messages ignored and best practices violated for users to need to use this command in the first place. Maybe an app or LSP shouldn't rely on the existence of this command and instead assure proper backups and safety guidelines?

@Darth-Coin
Copy link

@guggero Thank you very much!
How we end up in this shity situation? Exactly testing a lot all kind of situations with Zeus and Blixt.
I explained in this discussion all I tested with Zeus: ZeusLN/zeus#2174

@guggero
Copy link
Member

guggero commented Jun 15, 2024

Ah, the classic, RBFing a channel funding transaction. It's interesting to me how many users there are who know enough to pull it off but not enough to know they shouldn't... Maybe it would be worth adding warnings to the RBF dialog in Sparrow/Electrum to inform users they shouldn't do it with channel funding transactions.

@Darth-Coin
Copy link

I end up importing the wallet into Sparrow because the opening channel and bump fee in Zeus was non-responsive.
In Zeus you have the option to bump the fee, but in my case, without any warning or error message was not responding.
So I thought that something is wrong with Zeus and wanted to try doing it from Sparrow.

Maybe, as you said, adding a warning message in Zeus, about the bumping fee, for that particular opening channel tx is not possible (due to x reason), so the user will know what is the cause and calm down.

@guggero
Copy link
Member

guggero commented Jun 28, 2024

@Darth-Coin any update on testing this?

@Darth-Coin
Copy link

Darth-Coin commented Jun 28, 2024

@guggero oh sorry, I saw #141 still open and I thought is not ready yet.
Will talk with @hsjoberg to see if he's available to finish what we started.
Thanks for heads up! Will get to you with a feedback after I finish with Hampus the recovery.

@4rkad
Copy link

4rkad commented Jul 31, 2024

About 15 days ago I had a forced closure on Zeus and I was waiting for 2 weeks to be able to access to onchain funds. I was unable to do so so I went to the Chantools documentation to recover them but I was unsuccessful. Looking at this thread I realized that my channel was opened with the Olympus LSP via taproot. Do I have to wait for an update to be able to recover the funds?

@guggero
Copy link
Member

guggero commented Jul 31, 2024

A normal force closure should just be resolved automatically by lnd within Zeus (assuming you didn't lose your channel state). So I'd just file an issue with them, perhaps it's another issue? You don't need to use chantools if you don't lose your channel state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants