Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiat: Expand currency offering #38

Closed
carlaKC opened this issue May 27, 2020 · 1 comment
Closed

fiat: Expand currency offering #38

carlaKC opened this issue May 27, 2020 · 1 comment
Labels
fiat related to fiat conversion package help wanted Extra attention is needed

Comments

@carlaKC
Copy link
Contributor

carlaKC commented May 27, 2020

As is, we only obtain fiat quotes in USD. More options would be nice for non-dollar denominated users.

[Possible solutions, still in progress]
Investigate whether coincap (currently used price backends) provides other pairs. If not, look at other backends (also relevant for #37) or look at converting BTC -> USD -> Other Currency. Preferably the first option, since each conversion loses accuracy.

@carlaKC
Copy link
Contributor Author

carlaKC commented Jun 17, 2021

I think that the solution we have in #122 is a more flexible way of allowing multiple currency options. We can sink endless resources into adding new backends/ currencies, so let's rather allow use of the reporting functionality with custom data and re-open this issue if there's demand for additional built in currencies.

@carlaKC carlaKC closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiat related to fiat conversion package help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant