Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot complete percentage is too fast #58

Open
alexrudd2 opened this issue Dec 9, 2023 · 0 comments · May be fixed by #59
Open

Plot complete percentage is too fast #58

alexrudd2 opened this issue Dec 9, 2023 · 0 comments · May be fixed by #59

Comments

@alexrudd2
Copy link
Collaborator

The 0 - 100% plot complete percentage (progress indicator) is too fast.

The EBB only has a FIFO queue of 3, so it's not there.
From cncserver documentation of PUT /v1/pen:

Request will not complete until movement is actually complete, though you can send more requests through separate channels.

The below code is likely the culprit.
https://github.com/lilkraftwerk/lineboi3000/blob/master/src/plotting/AxidrawAPI.js#L73-L81

At a minimum, I think it should be await result.json() rather than Promise.resolve(json). It might also need error handling?

@alexrudd2 alexrudd2 linked a pull request Dec 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant