Merge pull request #139 from lilt/4.x-latest-updates

4.x latest updates from 3.x

Author: hadomskyi

src/modules/FetchJobStatusFromConnector.php

@@ -96,7 +96,7 @@ public function execute($queue): void
             Craft::error([
                 "message" => sprintf(
                     'Set job %d and translations to status failed due to failed/cancel status from lilt',
-                    $jobRecord->id,
+                    $jobRecord->id
                 ),
                 "jobRecord" => $jobRecord,
             ]);
@@ -163,7 +163,7 @@ function (TranslationResponse $connectorTranslation) {
                 Craft::error([
                     "message" => sprintf(
                         'Set job %d and translations to status failed due to failed status for translation from lilt',
-                        $jobRecord->id,
+                        $jobRecord->id
                     ),
                     "jobRecord" => $jobRecord,
                 ]);
@@ -239,7 +239,7 @@ function (TranslationResponse $connectorTranslation) {
                 Craft::error([
                     "message" => sprintf(
                         'Set job %d and translations to status failed due to failed/cancel status from lilt',
-                        $jobRecord->id,
+                        $jobRecord->id
                     ),
                     "jobRecord" => $jobRecord,
                 ]);

src/modules/ManualJobSync.php

@@ -56,7 +56,7 @@ public function execute($queue): void
                 1,
                 Craft::t(
                     'app',
-                    'Syncing finished',
+                    'Syncing finished'
                 )
             );
 
@@ -74,7 +74,7 @@ public function execute($queue): void
                 1,
                 Craft::t(
                     'app',
-                    'Syncing finished',
+                    'Syncing finished'
                 )
             );
 

src/modules/QueueManager.php

@@ -35,7 +35,7 @@ public function execute($queue): void
                 1,
                 Craft::t(
                     'app',
-                    'Finished lilt queue manager',
+                    'Finished lilt queue manager'
                 )
             );
 
@@ -61,7 +61,7 @@ public function execute($queue): void
                 1,
                 Craft::t(
                     'app',
-                    'Finished lilt queue manager',
+                    'Finished lilt queue manager'
                 )
             );
 
@@ -90,7 +90,7 @@ public function execute($queue): void
             1,
             Craft::t(
                 'app',
-                'Finished lilt queue manager',
+                'Finished lilt queue manager'
             )
         );
 

src/modules/SendTranslationToConnector.php

@@ -113,7 +113,7 @@ public function execute($queue): void
                 sprintf(
                     'Can\'t find job %d for element %d',
                     $this->jobId,
-                    $this->versionId,
+                    $this->versionId
                 )
             );
         }

src/services/handlers/CreateDraftHandler.php

@@ -82,6 +82,19 @@ public function create(
 
         $this->copyFieldsHandler->copy($element, $draft);
 
+        $result = Craft::$app->elements->saveElement($draft, true, false, false);
+        if (!$result) {
+            Craft::error(
+                sprintf(
+                    "Can't save freshly created draft %d for site %s",
+                    $draft->id,
+                    Craftliltplugin::getInstance()->languageMapper->getLanguageBySiteId(
+                        $targetSiteId
+                    )
+                )
+            );
+        }
+
         $copyEntriesSlugFromSourceToTarget = SettingRecord::findOne(
             ['name' => 'copy_entries_slug_from_source_to_target']
         );

src/services/handlers/UpdateJobStatusHandler.php

@@ -54,7 +54,7 @@ public function update(int $jobId): void
             Craft::error([
                 "message" =>  sprintf(
                     'Set job %d and translations to status failed',
-                    $jobRecord->id,
+                    $jobRecord->id
                 ),
                 "jobRecord" => $jobRecord,
             ], 'lilt');
@@ -68,7 +68,7 @@ public function update(int $jobId): void
             Craft::warning([
                 "message" =>  sprintf(
                     'Set job %d and translations to status needs attention',
-                    $jobRecord->id,
+                    $jobRecord->id
                 ),
                 "jobRecord" => $jobRecord,
             ], 'lilt');

tests/integration/modules/ManualJobSyncCest.php

@@ -423,7 +423,7 @@ public function testNotStartedJobWithNotSentTranslations(IntegrationTester $I):
                     'elementId' => $translation->elementId,
                     'versionId' => $translation->versionId,
                     'targetSiteId' => $translation->targetSiteId,
-                ]),
+                ])
             );
         }