sshutil.go
handles key paths inconsistently on Windows platform
#3167
Labels
sshutil.go
handles key paths inconsistently on Windows platform
#3167
Description
Code in
sshutil.go
is different for path handling in different commands -ssh
vsssh-keygen
:It uses filepath for
ssh-keygen
lima/pkg/sshutil/sshutil.go
Line 99 in e911564
ssh
lima/pkg/sshutil/sshutil.go
Line 172 in e911564
It doesn't look right to mix and match ssh tools from Windows installation and msys2/cygwin counterparts, so, they both should work identically (cygwin/msys2 does support implicit conversion, but if one uses wsl based tooling it will not). The idea is to make this behavior more strict - identify which tooling version is used as Windows adds market to the version output. Alternatively it could be a setting inside VM template as of which kind of tooling is expected - this will reduce overhead of calling
ssh -V
additionally every time.I plan to work on a PR addressing this.
The text was updated successfully, but these errors were encountered: