Skip to content

Pass along the HSCDataset id for populating vectordb #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

drewoldag
Copy link
Collaborator

Copied the structure of shape(self).

@drewoldag drewoldag self-assigned this Jan 23, 2025
@drewoldag drewoldag linked an issue Jan 23, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.93%. Comparing base (839cf98) to head (b87a1bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/infer.py 0.00% 4 Missing ⚠️
src/fibad/data_sets/hsc_data_set.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   38.94%   38.93%   -0.02%     
==========================================
  Files          23       23              
  Lines        1977     1983       +6     
==========================================
+ Hits          770      772       +2     
- Misses       1207     1211       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2025

Before [839cf98] After [4dd23d3] Ratio Benchmark (Parameter)
3.94±1s 4.74±0.2s ~1.20 benchmarks.time_computation
1.18k 3.94k 3.33 benchmarks.mem_list

Click here to view all benchmarks.

@drewoldag drewoldag requested a review from mtauraso January 23, 2025 01:26
Copy link
Collaborator

@mtauraso mtauraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drewoldag drewoldag merged commit c829885 into main Jan 23, 2025
6 of 8 checks passed
@drewoldag drewoldag deleted the issue/177/hscdataset-id-for-vecdb branch January 23, 2025 05:53
mtauraso pushed a commit that referenced this pull request Jan 27, 2025
* Add method to pass along the HSCDataset id when populating the vector database.

* Casting the strings to ints as the come from the generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass object id as id for HSCDataset
2 participants