Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide useful factories for Change #17

Open
ikhoon opened this issue Oct 29, 2021 · 2 comments
Open

Provide useful factories for Change #17

ikhoon opened this issue Oct 29, 2021 · 2 comments
Labels
improvement

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Oct 29, 2021 •
edited
Loading

Change is a data class that only provides the default constructor.
It would be nice to offer various factories for users' convenience as like upstream Central Dogma did.
https://github.com/line/centraldogma/blob/ece893db888fbb5c4f1e28987b9aee10d78e5396/common/src/main/java/com/linecorp/centraldogma/common/Change.java#L65
@ikhoon ikhoon added this to the 0.1.0 milestone Oct 29, 2021
@ikhoon
Copy link
Contributor Author

ikhoon commented Jan 5, 2022

@minwoox If you are looking for an issue, how about this? I think this might be worth it to ship with the initial version. 😆

@minwoox
Copy link

minwoox commented Jan 5, 2022

Thanks for the suggestion. Yeah, let me handle this issue. 😄

@hexoul hexoul modified the milestones: 0.1.0, 0.2.0 Jul 3, 2022
@ikhoon ikhoon modified the milestones: 0.2.0, 0.3.0 Aug 17, 2022
@hexoul hexoul removed this from the 0.3.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ikhoon @hexoul @minwoox