Enable workspace lint configuration, fix lints (#19)

Author: waywardmonkeys

Cargo.toml

@@ -8,6 +8,10 @@ version = "0.3.0"
 license = "Apache-2.0 OR MIT"
 repository = "https://github.com/linebender/vello_svg"
 
+[workspace.lints]
+clippy.doc_markdown = "warn"
+clippy.semicolon_if_nothing_returned = "warn"
+
 [workspace.dependencies]
 # NOTE: Make sure to keep this in sync with the version badge in README.md
 vello = { version = "0.2.0", default-features = false }
@@ -22,6 +26,9 @@ license.workspace = true
 edition.workspace = true
 repository.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 vello = { workspace = true }
 thiserror = "1.0.61"

examples/run_wasm/Cargo.toml

@@ -5,5 +5,8 @@ license.workspace = true
 repository.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 cargo-run-wasm = "0.4.0"

examples/scenes/Cargo.toml

@@ -6,6 +6,9 @@ license.workspace = true
 repository.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 vello = { workspace = true }
 vello_svg = { path = "../.." }

examples/with_winit/Cargo.toml

@@ -16,6 +16,9 @@ crate-type = ["cdylib", "lib"]
 name = "with_winit_bin"
 path = "src/main.rs"
 
+[lints]
+workspace = true
+
 [dependencies]
 vello = { workspace = true, features = ["buffer_labels", "wgpu"] }
 scenes = { path = "../scenes" }

examples/with_winit/src/lib.rs

@@ -158,14 +158,14 @@ fn run(
                         if event.state == ElementState::Pressed {
                             match event.logical_key.as_ref() {
                                 Key::Named(NamedKey::ArrowLeft) => {
-                                    scene_ix = scene_ix.saturating_sub(1)
+                                    scene_ix = scene_ix.saturating_sub(1);
                                 }
                                 Key::Named(NamedKey::ArrowRight) => {
-                                    scene_ix = scene_ix.saturating_add(1)
+                                    scene_ix = scene_ix.saturating_add(1);
                                 }
                                 Key::Named(NamedKey::ArrowUp) => complexity += 1,
                                 Key::Named(NamedKey::ArrowDown) => {
-                                    complexity = complexity.saturating_sub(1)
+                                    complexity = complexity.saturating_sub(1);
                                 }
                                 Key::Named(NamedKey::Space) => {
                                     transform = Affine::IDENTITY;

src/lib.rs

@@ -95,5 +95,5 @@ pub fn append_tree_with<F: FnMut(&mut vello::Scene, &usvg::Node)>(
     svg: &usvg::Tree,
     error_handler: &mut F,
 ) {
-    render::render_group(scene, svg.root(), error_handler)
+    render::render_group(scene, svg.root(), error_handler);
 }

src/render.rs

@@ -60,7 +60,7 @@ pub(crate) fn render_group<F: FnMut(&mut Scene, &usvg::Node)>(
                                 &local_path,
                             );
                         } else {
-                            error_handler(scene, node)
+                            error_handler(scene, node);
                         }
                     }
                 };
@@ -78,7 +78,7 @@ pub(crate) fn render_group<F: FnMut(&mut Scene, &usvg::Node)>(
                                 &local_path,
                             );
                         } else {
-                            error_handler(scene, node)
+                            error_handler(scene, node);
                         }
                     }
                 };

src/util.rs

@@ -52,13 +52,13 @@ pub fn to_bez_path(path: &usvg::Path) -> BezPath {
                     local_path.move_to(most_recent_initial);
                 }
                 most_recent_initial = (p.x.into(), p.y.into());
-                local_path.move_to(most_recent_initial)
+                local_path.move_to(most_recent_initial);
             }
             usvg::tiny_skia_path::PathSegment::LineTo(p) => {
                 if std::mem::take(&mut just_closed) {
                     local_path.move_to(most_recent_initial);
                 }
-                local_path.line_to(Point::new(p.x as f64, p.y as f64))
+                local_path.line_to(Point::new(p.x as f64, p.y as f64));
             }
             usvg::tiny_skia_path::PathSegment::QuadTo(p1, p2) => {
                 if std::mem::take(&mut just_closed) {
@@ -67,7 +67,7 @@ pub fn to_bez_path(path: &usvg::Path) -> BezPath {
                 local_path.quad_to(
                     Point::new(p1.x as f64, p1.y as f64),
                     Point::new(p2.x as f64, p2.y as f64),
-                )
+                );
             }
             usvg::tiny_skia_path::PathSegment::CubicTo(p1, p2, p3) => {
                 if std::mem::take(&mut just_closed) {
@@ -77,11 +77,11 @@ pub fn to_bez_path(path: &usvg::Path) -> BezPath {
                     Point::new(p1.x as f64, p1.y as f64),
                     Point::new(p2.x as f64, p2.y as f64),
                     Point::new(p3.x as f64, p3.y as f64),
-                )
+                );
             }
             usvg::tiny_skia_path::PathSegment::Close => {
                 just_closed = true;
-                local_path.close_path()
+                local_path.close_path();
             }
         }
     }