Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync get, getAll, batchGet, and search getInternal behavior #136

Open
jsdonn opened this issue Nov 3, 2021 · 0 comments
Open

Sync get, getAll, batchGet, and search getInternal behavior #136

jsdonn opened this issue Nov 3, 2021 · 0 comments

Comments

@jsdonn
Copy link
Contributor

jsdonn commented Nov 3, 2021

Is your feature request related to a problem? Please describe.

PR#132 changes the intended behavior of get() when parameter aspectNames is empty. Instead of throwing a 404, it will return VALUE with no aspects. To accomplish this behavior, getInternalNonEmpty call was changed to getInternal. We need to evaluate this behavior with getAll(), batchGet(), and search() methods to make sure they are aligned with get()'s new behavior.

Describe the solution you'd like

Double check and update calls to getInternalNonEmpty if needed to match with new get() behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant