Shade Netty into r2. #780
Open
Shade Netty into r2. #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpstewart
added
the
backward-incompatible
jpstewart
force-pushed
the
netty-shading
branch
from
be91348 to
7e2d161
Compare
evanw555
reviewed
May 4, 2022
evanw555
reviewed
May 4, 2022
evanw555
reviewed
May 4, 2022
jpstewart
removed
the
backward-incompatible
jpstewart
requested review from
FreeMem17
and removed request for
FranklinYinanDing,
aman1309,
bbarkley and
nizarm
FreeMem17
reviewed
May 13, 2022
r2-netty/src/test/java/com/linkedin/r2/transport/http/client/TestHttpNettyStreamClient.java
Show resolved
Hide resolved
jpstewart
force-pushed
the
netty-shading
branch
4 times, most recently
from
9741e9a to
d223826
Compare
li-bsoetarman
approved these changes
May 26, 2022
Contributor
li-bsoetarman
left a comment
li-bsoetarman
left a comment
There was a problem hiding this comment.
What about the sources jar and the javadoc jar for the shadow? The debugger would not the sources jar.
jpstewart
force-pushed
the
netty-shading
branch
from
bc99586 to
d3ecee1
Compare
jpstewart
force-pushed
the
netty-shading
branch
from
d3ecee1 to
d73891d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shades Netty into a restli-netty package, with relocates the classes under com.linkedin.pegasus, to avoid conflicts with end users' own Netty version. Based on previous PR, with some modifications and fixes for some outstanding issues inthe shadow plugin and IntelliJ handling for shadowing. (#595).