Skip to content

Commit f23b297

Browse files
authored
Properly set log level for hickory_resolver in proxy (#3019)
Followup to #2872 , where we swapped the trust-dns-resolver with the hickory-resolver dependency. We had mistakingly changed the default log level to `hickory_dns=error` when it should have been `hickory_resolver=error`.
1 parent 49336fd commit f23b297

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

deny.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ skip = [
7575
# https://github.com/hawkw/matchers/pull/4
7676
{ name = "regex-automata", version = "0.1" },
7777
{ name = "regex-syntax", version = "0.6" },
78-
# `trust-dns-proto`, depends on `idna` v0.2.3 while `url` depends on v0.5.0
78+
# `trust-dns-proto`, depends on `idna` v0.4.0 while `url` depends on v0.5.0
7979
{ name = "idna" },
8080
# Some dependencies still use indexmap v1.
8181
{ name = "indexmap", version = "1" },

linkerd/app/core/src/dns.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ impl Config {
2424
}
2525

2626
impl ConfigureResolver for Config {
27-
/// Modify a `trust-dns-resolver::config::ResolverOpts` to reflect
27+
/// Modify a `hickory-resolver::config::ResolverOpts` to reflect
2828
/// the configured minimum and maximum DNS TTL values.
2929
fn configure_resolver(&self, opts: &mut ResolverOpts) {
3030
opts.positive_min_ttl = self.min_ttl;

linkerd/dns/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ impl Resolver {
6464
}
6565

6666
pub fn new(config: ResolverConfig, mut opts: ResolverOpts) -> Self {
67-
// Disable Trust-DNS's caching.
67+
// Disable Hickory-resolver's caching.
6868
opts.cache_size = 0;
6969
// This function is synchronous, but needs to be called within the Tokio
7070
// 0.2 runtime context, since it gets a handle.

linkerd/tracing/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const ENV_LOG_LEVEL: &str = "LINKERD2_PROXY_LOG";
2626
const ENV_LOG_FORMAT: &str = "LINKERD2_PROXY_LOG_FORMAT";
2727
const ENV_ACCESS_LOG: &str = "LINKERD2_PROXY_ACCESS_LOG";
2828

29-
const DEFAULT_LOG_LEVEL: &str = "warn,linkerd=info,hickory_dns=error";
29+
const DEFAULT_LOG_LEVEL: &str = "warn,linkerd=info,hickory=error";
3030
const DEFAULT_LOG_FORMAT: &str = "PLAIN";
3131

3232
#[derive(Debug, Default)]

0 commit comments

Comments
 (0)