Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Repo housekeeping ideas #2

Open
3 of 8 tasks
sujaypatil96 opened this issue Feb 28, 2022 · 4 comments
Open
3 of 8 tasks

Repo housekeeping ideas #2

sujaypatil96 opened this issue Feb 28, 2022 · 4 comments
Assignees

Comments

@sujaypatil96
Copy link
Member

sujaypatil96 commented Feb 28, 2022

This is a great improvement over the previously existing linkml-template repo @turbomam, thank you for this.

I had a few quick, trivial housekeeping suggestions I wanted to document in this issue:

  • Transfer repo over to linkml org.
    • When you transfer the repo and possibly rename it, you probably shouldn't use the previous name, i.e., linkml-model-template since it might interfere with downstream repos which already use that version of the template
  • Possible alternatives:
    • linkml-model-template-v2
    • ideas?
  • Add CONTRIBUTING.md
  • Remove placeholder.txt from model folder
  • Archive linkml-model-template repo

Pass on these for now?

Discussed at 2022-03-04 LinkML call. Can revisit if necessary.

  • Move kitchen_sink.yaml into a subfolder called etc within model. So basically you'd have: model > etc > kitchen_sink.yaml
  • core.yaml can either be in the top level model folder or in a sub folder called core
@cmungall
Copy link
Member

Thanks!!!

linkml-model-template-v2

let's not do this. We can move the existing one to linkml-model-template-legacy.

We should have a single clear source of truth optio

@cmungall
Copy link
Member

@cmungall
Copy link
Member

I now favor this layout:

  • pyproject.toml
  • about.yaml
  • LICENSE
  • README.md
  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • src
    • linkml
      • my_project_name.yaml
    • my_project_name
      • datamodel
        * my_project_name.py
  • generated
    • jsonschema
    • owl
    • linkml
    • shacl
    • ...etc

Made a start:

@cthoyt
Copy link

cthoyt commented Mar 22, 2022

  1. if you put CODE_OF_CONDUCT.md inside a .github folder, it gets picked up by GitHub
  2. the datamodel/my_project_name.py seems redundant. Why not just datamodel.py or even better just models.py
  3. Would suggest keeping the linkml folder inside src/my_project_name/ if you want it to get redistributed with the package

cmungall added a commit to linkml/linkml-runtime that referenced this issue Mar 24, 2022
cmungall added a commit to linkml/linkml-runtime that referenced this issue Mar 24, 2022
Adding src path to list of paths to search when retrieving a schema by package name. See linkml/linkml-project-template#2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants