lint fixes and add lint to CIDI (#377)

* lint fixes and add lint to CIDI

* enable more tests

* fix tests

* update travis

* gomod tidy

* update travis golang version

* extend golangci deadline

* remove wrong fmt and fix the duplicated proto bug

Author: Stumble

.golangci.yml

@@ -1,5 +1,5 @@
 run:
-  deadline: 1m
+  deadline: 5m
 
 linters:
   enable-all: true

.travis.yml

@@ -1,7 +1,11 @@
 language: go
+go:
+- 1.12.9
 install:
 - make get_tools
+- make get_golangci_lint
 script:
+- make lint
 - make build
 - make install
 - make test

Makefile

@@ -48,18 +48,18 @@ benchmark:
 GOLANGCI_LINT_VERSION := v1.17.1
 GOLANGCI_LINT_HASHSUM := f5fa647a12f658924d9f7d6b9628d505ab118e8e049e43272de6526053ebe08d
 
-get-golangci-lint:
+get_golangci_lint:
 	cd scripts && bash install-golangci-lint.sh $(GOPATH)/bin $(GOLANGCI_LINT_VERSION) $(GOLANGCI_LINT_HASHSUM)
 
 lint:
-	@golangci-lint run
-	go mod verify
+	GO111MODULE=$(GO111MODULE) golangci-lint run
+	GO111MODULE=$(GO111MODULE) go mod verify
 
 lint-fix:
 	@echo "--> Running linter auto fix"
-	@golangci-lint run --fix
-	find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s
-	go mod verify
+	GO111MODULE=$(GO111MODULE) golangci-lint run --fix
+	GO111MODULE=$(GO111MODULE) find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s
+	GO111MODULE=$(GO111MODULE) go mod verify
 
 .PHONY: lint lint-fix
 

app/app.go

@@ -47,7 +47,6 @@ import (
 	abci "github.com/tendermint/tendermint/abci/types"
 	tmtypes "github.com/tendermint/tendermint/types"
 	dbm "github.com/tendermint/tm-db"
-	cmn "github.com/tendermint/tmlibs/common"
 )
 
 const (
@@ -187,7 +186,7 @@ func NewLinoBlockchain(
 		lb.CapKeyVoteStore, lb.CapKeyInfraStore, lb.CapKeyDeveloperStore, lb.CapKeyGlobalStore,
 		lb.CapKeyParamStore, lb.CapKeyProposalStore, lb.CapKeyReputationV2Store, lb.CapKeyBandwidthStore)
 	if err := lb.LoadLatestVersion(lb.CapKeyMainStore); err != nil {
-		cmn.Exit(err.Error())
+		panic(err)
 	}
 
 	lb.Seal()
@@ -420,8 +419,14 @@ func (lb *LinoBlockchain) beginBlocker(ctx sdk.Context, req abci.RequestBeginBlo
 		panic(err)
 	}
 	if chainStartTime == 0 {
-		lb.globalManager.SetChainStartTime(ctx, ctx.BlockHeader().Time.Unix())
-		lb.globalManager.SetLastBlockTime(ctx, ctx.BlockHeader().Time.Unix())
+		err := lb.globalManager.SetChainStartTime(ctx, ctx.BlockHeader().Time.Unix())
+		if err != nil {
+			panic(err)
+		}
+		err = lb.globalManager.SetLastBlockTime(ctx, ctx.BlockHeader().Time.Unix())
+		if err != nil {
+			panic(err)
+		}
 		chainStartTime = ctx.BlockHeader().Time.Unix()
 	}
 
@@ -461,13 +466,16 @@ func (lb *LinoBlockchain) executeTimeEvents(ctx sdk.Context) {
 	for i := lastBlockTime; i < currentTime; i++ {
 		if timeEvents := lb.globalManager.GetTimeEventListAtTime(ctx, i); timeEvents != nil {
 			lb.executeEvents(ctx, timeEvents.Events)
-			lb.globalManager.RemoveTimeEventList(ctx, i)
+			err := lb.globalManager.RemoveTimeEventList(ctx, i)
+			if err != nil {
+				panic(err)
+			}
 		}
 	}
 }
 
 // execute events in list based on their type
-func (lb *LinoBlockchain) executeEvents(ctx sdk.Context, eventList []types.Event) sdk.Error {
+func (lb *LinoBlockchain) executeEvents(ctx sdk.Context, eventList []types.Event) {
 	for _, event := range eventList {
 		switch e := event.(type) {
 		case posttypes.RewardEvent:
@@ -492,7 +500,6 @@ func (lb *LinoBlockchain) executeEvents(ctx sdk.Context, eventList []types.Event
 			ctx.Logger().Error(fmt.Sprintf("skipping event: %+v", e))
 		}
 	}
-	return nil
 }
 
 // udpate validator set and renew reputation round
@@ -542,15 +549,27 @@ func (lb *LinoBlockchain) increaseMinute(ctx sdk.Context) {
 // execute hourly event, distribute inflation to validators and
 // add hourly inflation to content creator reward pool
 func (lb *LinoBlockchain) executeHourlyEvent(ctx sdk.Context) {
-	lb.globalManager.DistributeHourlyInflation(ctx)
+	err := lb.globalManager.DistributeHourlyInflation(ctx)
+	if err != nil {
+		panic(err)
+	}
 	lb.distributeInflationToValidator(ctx)
-	lb.bandwidthManager.ReCalculateAppBandwidthInfo(ctx)
+	err = lb.bandwidthManager.ReCalculateAppBandwidthInfo(ctx)
+	if err != nil {
+		panic(err)
+	}
 }
 
 // execute daily event, record consumption friction and lino power
 func (lb *LinoBlockchain) executeDailyEvent(ctx sdk.Context) {
-	lb.globalManager.RecordConsumptionAndLinoStake(ctx)
-	lb.bandwidthManager.DecayMaxMPS(ctx)
+	err := lb.globalManager.RecordConsumptionAndLinoStake(ctx)
+	if err != nil {
+		panic(err)
+	}
+	err = lb.bandwidthManager.DecayMaxMPS(ctx)
+	if err != nil {
+		panic(err)
+	}
 }
 
 // execute monthly event, distribute inflation to infra and application
@@ -564,7 +583,7 @@ func (lb *LinoBlockchain) executeMonthlyEvent(ctx sdk.Context) {
 
 }
 
-func (lb *LinoBlockchain) executeAnnuallyEvent(ctx sdk.Context) {
+func (lb *LinoBlockchain) executeAnnuallyEvent(ctx sdk.Context) { //nolint:unused
 	if err := lb.globalManager.SetTotalLinoAndRecalculateGrowthRate(ctx); err != nil {
 		panic(err)
 	}
@@ -589,7 +608,10 @@ func (lb *LinoBlockchain) distributeInflationToValidator(ctx sdk.Context) {
 		// though only differs in round?
 		ratPerValidator = coin.ToDec().Quo(sdk.NewDec(int64(len(lst.OncallValidators) - i)))
 		coinPerValidator := types.DecToCoin(ratPerValidator)
-		lb.accountManager.AddCoinToUsername(ctx, validator, coinPerValidator)
+		err := lb.accountManager.AddCoinToUsername(ctx, validator, coinPerValidator)
+		if err != nil {
+			panic(err)
+		}
 		coin = coin.Minus(coinPerValidator)
 	}
 }
@@ -609,7 +631,10 @@ func (lb *LinoBlockchain) distributeInflationToInfraProvider(ctx sdk.Context) {
 	totalDistributedInflation := types.NewCoinFromInt64(0)
 	for idx, provider := range lst.AllInfraProviders {
 		if idx == (len(lst.AllInfraProviders) - 1) {
-			lb.accountManager.AddCoinToUsername(ctx, provider, inflation.Minus(totalDistributedInflation))
+			err := lb.accountManager.AddCoinToUsername(ctx, provider, inflation.Minus(totalDistributedInflation))
+			if err != nil {
+				panic(fmt.Errorf("%s: %s", err, provider))
+			}
 			break
 		}
 		percentage, err := lb.infraManager.GetUsageWeight(ctx, provider)
@@ -619,7 +644,10 @@ func (lb *LinoBlockchain) distributeInflationToInfraProvider(ctx sdk.Context) {
 		myShareRat := inflation.ToDec().Mul(percentage)
 		myShareCoin := types.DecToCoin(myShareRat)
 		totalDistributedInflation = totalDistributedInflation.Plus(myShareCoin)
-		lb.accountManager.AddCoinToUsername(ctx, provider, myShareCoin)
+		err = lb.accountManager.AddCoinToUsername(ctx, provider, myShareCoin)
+		if err != nil {
+			panic(err)
+		}
 	}
 	if err := lb.infraManager.ClearUsage(ctx); err != nil {
 		panic(err)
@@ -660,12 +688,18 @@ func (lb *LinoBlockchain) ExportAppStateAndValidators() (appState json.RawMessag
 		}
 		defer f.Close()
 		jsonbytes, err := lb.cdc.MarshalJSON(exporter(ctx))
-		f.Write(jsonbytes)
 		if err != nil {
 			panic("failed to marshal json for " + filename + " due to " + err.Error())
 		}
+		_, err = f.Write(jsonbytes)
+		if err != nil {
+			panic(err)
+		}
 		fmt.Printf("export for %s done: %d bytes\n", filename, len(jsonbytes))
-		f.Sync()
+		err = f.Sync()
+		if err != nil {
+			panic(err)
+		}
 	}
 
 	// TODO(yumin): accountStateFile
@@ -693,7 +727,10 @@ func (lb *LinoBlockchain) ExportAppStateAndValidators() (appState json.RawMessag
 	exportToFile(voterStateFile, func(ctx sdk.Context) interface{} {
 		return lb.voteManager.Export(ctx).ToIR()
 	})
-	lb.reputationManager.ExportToFile(ctx, exportPath+"reputation")
+	err = lb.reputationManager.ExportToFile(ctx, exportPath+"reputation")
+	if err != nil {
+		panic(err)
+	}
 
 	genesisState := GenesisState{}
 

app/app_test.go

@@ -1,3 +1,4 @@
+//nolint:deadcode,unused
 package app
 
 import (
@@ -324,7 +325,10 @@ func TestDistributeInflationToValidators(t *testing.T) {
 	for i := 0; i < len(expectBalanceList); i++ {
 		expectBalanceList[i] = expectBaseBalance
 	}
-	lb.globalManager.DistributeHourlyInflation(ctx)
+	err := lb.globalManager.DistributeHourlyInflation(ctx)
+	if err != nil {
+		panic(err)
+	}
 	lb.distributeInflationToValidator(ctx)
 	// simulate app
 	// hourly inflation
@@ -467,8 +471,11 @@ func TestDistributeInflationToInfraProvider(t *testing.T) {
 			}
 			infra, _ := infraStorage.GetInfraProvider(ctx, types.AccountKey("infra"+strconv.Itoa(i)))
 			infra.Usage = cs.consumptionList[i]
-			infraStorage.SetInfraProvider(ctx, types.AccountKey("infra"+strconv.Itoa(i)), infra)
-			totalWeight = totalWeight + cs.consumptionList[i]
+			err = infraStorage.SetInfraProvider(ctx, types.AccountKey("infra"+strconv.Itoa(i)), infra)
+			if err != nil {
+				panic(err)
+			}
+			totalWeight += cs.consumptionList[i]
 		}
 		globalStore := globalModel.NewGlobalStorage(lb.CapKeyGlobalStore)
 		err := globalStore.SetInflationPool(ctx, &globalModel.InflationPool{
@@ -532,7 +539,10 @@ func TestDistributeInflationToInfraProvider(t *testing.T) {
 		if err != nil {
 			t.Errorf("%s: failed to set past minutes, got err %v", testName, err)
 		}
-		err = lb.infraManager.RegisterInfraProvider(ctx, "Lino")
+		_ = lb.accountManager.CreateAccount(
+			ctx, types.AccountKey("lino"),
+			secp256k1.GenPrivKey().PubKey(), secp256k1.GenPrivKey().PubKey())
+		err = lb.infraManager.RegisterInfraProvider(ctx, "lino")
 		if err != nil {
 			t.Errorf("%s: failed to register infra provider, got err %v", testName, err)
 		}
@@ -624,9 +634,15 @@ func TestIncreaseMinute(t *testing.T) {
 	for i := 1; i < types.MinutesPerMonth/10; i++ {
 		// simulate add lino stake and friction at previous block
 		ctx := lb.BaseApp.NewContext(true, abci.Header{Time: time.Unix(int64((i-1)*60), 0)})
-		lb.globalManager.AddLinoStakeToStat(ctx, types.NewCoinFromInt64(1))
-		lb.globalManager.AddFrictionAndRegisterContentRewardEvent(
+		err := lb.globalManager.AddLinoStakeToStat(ctx, types.NewCoinFromInt64(1))
+		if err != nil {
+			panic(err)
+		}
+		err = lb.globalManager.AddFrictionAndRegisterContentRewardEvent(
 			ctx, posttypes.RewardEvent{}, types.NewCoinFromInt64(2), types.NewMiniDollar(1))
+		if err != nil {
+			panic(err)
+		}
 		expectLinoStakeStat.TotalConsumptionFriction =
 			expectLinoStakeStat.TotalConsumptionFriction.Plus(types.NewCoinFromInt64(2))
 		expectLinoStakeStat.UnclaimedFriction =

app/genesis.go

@@ -17,12 +17,6 @@ import (
 	tmtypes "github.com/tendermint/tendermint/types"
 )
 
-var (
-	flagName       = "name"
-	flagClientHome = "home-client"
-	flagOWK        = "owk"
-)
-
 // genesis state for blockchain
 type GenesisState struct {
 	LoadPrevStates bool                      `json:"load_prev_states"`

app/genesis_test.go

@@ -142,7 +142,7 @@ func TestGetGenesisJson(t *testing.T) {
 	appState, err := wire.MarshalJSONIndent(cdc, genesisState)
 	assert.Nil(t, err)
 	appGenesisState := new(GenesisState)
-	err = cdc.UnmarshalJSON([]byte(appState), appGenesisState)
+	err = cdc.UnmarshalJSON(appState, appGenesisState)
 	assert.Nil(t, err)
 
 	assert.Equal(t, genesisState, *appGenesisState)

client/common.go

@@ -21,7 +21,7 @@ func parsePrivKey(key string) (crypto.PrivKey, error) {
 	if err != nil {
 		return privKey, err
 	}
-	privKey, _ = cryptoAmino.PrivKeyFromBytes(privKeyBytes)
+	privKey, err = cryptoAmino.PrivKeyFromBytes(privKeyBytes)
 	if err != nil {
 		return privKey, err
 	}

cmd/lino/main.go

@@ -45,7 +45,10 @@ func main() {
 	server.AddCommands(ctx, cdc, rootCmd, newApp, exportAppStateAndTMValidators)
 
 	executor := cli.PrepareBaseCmd(rootCmd, "BC", app.DefaultNodeHome)
-	executor.Execute()
+	err := executor.Execute()
+	if err != nil {
+		panic(err)
+	}
 }
 
 func exportAppStateAndTMValidators(logger log.Logger, db dbm.DB, traceStore io.Writer,

go.mod

@@ -15,8 +15,6 @@ require (
 	github.com/tendermint/go-amino v0.15.0
 	github.com/tendermint/tendermint v0.32.2
 	github.com/tendermint/tm-db v0.1.1
-	github.com/tendermint/tmlibs v0.9.0
 	golang.org/x/sys v0.0.0-20190329044733-9eb1bfa1ce65 // indirect
-	google.golang.org/appengine v1.4.0 // indirect
 	google.golang.org/genproto v0.0.0-20190327125643-d831d65fe17d // indirect
 )

go.sum

@@ -187,8 +187,6 @@ github.com/tendermint/tendermint v0.32.2 h1:FvZWdksfDg/65vKKr5Lgo57keARFnmhrUEXH
 github.com/tendermint/tendermint v0.32.2/go.mod h1:NwMyx58S8VJ7tEpFKqRVlVWKO9N9zjTHu+Dx96VsnOE=
 github.com/tendermint/tm-db v0.1.1 h1:G3Xezy3sOk9+ekhjZ/kjArYIs1SmwV+1OUgNkj7RgV0=
 github.com/tendermint/tm-db v0.1.1/go.mod h1:0cPKWu2Mou3IlxecH+MEUSYc1Ch537alLe6CpFrKzgw=
-github.com/tendermint/tmlibs v0.9.0 h1:3aU/D2v3aecqpODOuBXCfi950bHTefD5Pps5X3XuJDc=
-github.com/tendermint/tmlibs v0.9.0/go.mod h1:4L0tAKpLTioy14VnmbXYTLIJN0pCMiehxDMdN6zZfM8=
 github.com/ugorji/go/codec v0.0.0-20181204163529-d75b2dcb6bc8/go.mod h1:VFNgLljTbGfSG7qAOspJ7OScBnGdDN/yBr0sguwnwf0=
 github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77/go.mod h1:aYKd//L2LvnjZzWKhF00oedf4jCCReLcmhLdhm1A27Q=
 github.com/zondax/hid v0.9.0 h1:eiT3P6vNxAEVxXMw66eZUAAnU2zD33JBkfG/EnfAKl8=

param/holder_test.go

@@ -1,3 +1,4 @@
+//nolint:unused
 package param
 
 import (
@@ -21,7 +22,10 @@ func getContext() sdk.Context {
 	db := dbm.NewMemDB()
 	ms := store.NewCommitMultiStore(db)
 	ms.MountStoreWithDB(TestKVStoreKey, sdk.StoreTypeIAVL, db)
-	ms.LoadLatestVersion()
+	err := ms.LoadLatestVersion()
+	if err != nil {
+		panic(err)
+	}
 
 	return sdk.NewContext(ms, abci.Header{}, false, log.NewNopLogger())
 }
@@ -206,7 +210,10 @@ func TestInitParam(t *testing.T) {
 	ph := NewParamHolder(TestKVStoreKey)
 	ctx := getContext()
 
-	ph.InitParam(ctx)
+	err := ph.InitParam(ctx)
+	if err != nil {
+		panic(err)
+	}
 
 	globalAllocationParam := GlobalAllocationParam{
 		GlobalGrowthRate:         types.NewDecFromRat(98, 1000),

test/test_util.go

@@ -202,7 +202,7 @@ func CreateAccount(
 	numOfLino string) {
 
 	registerMsg := acctypes.NewRegisterMsg(
-		GenesisUser, accountName, types.LNO(numOfLino),
+		GenesisUser, accountName, numOfLino,
 		resetPriv.PubKey(), transactionPriv.PubKey(), appPriv.PubKey())
 	SignCheckDeliver(t, lb, registerMsg, seq, true, GenesisTransactionPriv, time.Now().Unix())
 }

test/validator/deposit_test.go

@@ -74,7 +74,7 @@ func TestRegisterValidatorOneByOne(t *testing.T) {
 		test.SignCheckDeliver(t, lb, voteDepositMsg, 0, true, newAccountTransactionPriv, baseTime)
 
 		valDepositMsg := val.NewValidatorDepositMsg(
-			newAccountName, types.LNO(strconv.Itoa(120000+100*seq)), newValidatorPriv.PubKey(), "")
+			newAccountName, strconv.Itoa(120000+100*seq), newValidatorPriv.PubKey(), "")
 		test.SignCheckDeliver(t, lb, valDepositMsg, 1, true, newAccountTransactionPriv, baseTime)
 		test.CheckOncallValidatorList(t, newAccountName, true, lb)
 		test.CheckAllValidatorList(t, newAccountName, true, lb)