fix: start a timer in another thread #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18202781743
reviewed
Feb 13, 2025
| @@ -596,8 +596,8 @@ void NotificationManager::onHandingPendingEntities() | |||
| // find last point to restart pendingTimeout | |||
| m_lastTimeoutPoint = points.first(); | |||
| auto newInterval = m_lastTimeoutPoint - current; | |||
| m_pendingTimeout->setInterval(newInterval); | |||
| m_pendingTimeout->start(); | |||
| // let timer start in main thread | |||
There was a problem hiding this comment.
出问题的是从主线程调过来的吧，timer应该一直是子线程的，
18202781743
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
as title Log: as title Pms: BUG-297399
yixinshark
force-pushed
the
fix-bubbleTimeout
branch
from
f879f6d to
e1128ec
Compare
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
Log: as title
Pms: BUG-297399