Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speakers block dropdown sometimes hidden #933

Closed
cjyabraham opened this issue Aug 16, 2024 · 1 comment
Closed

Speakers block dropdown sometimes hidden #933

cjyabraham opened this issue Aug 16, 2024 · 1 comment
Assignees

Comments

@cjyabraham
Copy link
Collaborator

Speakers block uses the react-select component that has an open issue with the z-index of the dropdown and an open PR to fix it. When this gets committed we should update our code to pull in the fix. Problem shown below:

Screenshot 2024-08-16 at 11 23 30 AM

@cjyabraham cjyabraham self-assigned this Aug 18, 2024
cjyabraham added a commit that referenced this issue Aug 19, 2024
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
@cjyabraham
Copy link
Collaborator Author

Fixing this appears to be a bit of a whack-a-mole. I believe, however, that the most common case of this issue is when a Speakers block is nested inside of a Group block. The dropdown won't show beyond the limits of the Group block since it is nested inside of it. The fix I've applied corrects for this case. There may be some side-effects of this fix on Group blocks since we're changing the overflow setting on them. If any are found and they pose a problem, we can revert this fix.

There may be other cases where blocks hide a portion of the select drop-down. If we can know about these cases we can work on fixing them as well.

One other case I do know about is when the SEO bar at the bottom of a page blocks the drop-down. I'm not sure how common a problem this may be, how often the Speakers block would reside so low down on a page. If it is a common problem then we can work on a fix for this as well.

@cjyabraham cjyabraham mentioned this issue Aug 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant