Skip to content

Commit fe3bd66

Browse files
committed
AWS Lambda: Fix asserts for tests, include require
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
1 parent 44017aa commit fe3bd66

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pkg/middlewares/awslambda/aws_lambda_test.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313

1414
"github.com/aws/aws-lambda-go/events"
1515
"github.com/stretchr/testify/assert"
16+
"github.com/stretchr/testify/require"
1617
"github.com/traefik/traefik/v2/pkg/config/dynamic"
1718
"github.com/traefik/traefik/v2/pkg/tracing"
1819
)
@@ -85,7 +86,7 @@ func Test_AWSLambdaMiddleware_Invoke(t *testing.T) {
8586
rBody, _ := io.ReadAll(resp.Body)
8687

8788
assert.Equal(t, []byte("response_body"), rBody)
88-
assert.Equal(t, resp.StatusCode, http.StatusTeapot)
89+
assert.Equal(t, http.StatusTeapot, resp.StatusCode)
8990
}
9091

9192
// Test_AWSLambdaMiddleware_GetTracingInformation tests that the
@@ -107,12 +108,12 @@ func Test_AWSLambdaMiddleware_GetTracingInformation(t *testing.T) {
107108
// Test_AWSLambdaMiddleware_bodyToBase64_empty
108109
func Test_AWSLambdaMiddleware_bodyToBase64_empty(t *testing.T) {
109110
req, err := http.NewRequest(http.MethodGet, "/", nil)
110-
assert.NoError(t, err)
111+
require.NoError(t, err)
111112
isEncoded, body, err := bodyToBase64(req)
112113

113-
assert.Equal(t, isEncoded, false)
114-
assert.Equal(t, body, "")
115-
assert.Nil(t, err)
114+
assert.False(t, isEncoded)
115+
assert.Equal(t, "", body)
116+
require.NoError(t, err)
116117
}
117118

118119
// Test_AWSLambdaMiddleware_bodyToBase64_withcontent
@@ -121,10 +122,10 @@ func Test_AWSLambdaMiddleware_bodyToBase64_withcontent(t *testing.T) {
121122
reqBody := `{"test": "encoded"}`
122123

123124
req, err := http.NewRequest(http.MethodGet, "/", strings.NewReader(reqBody))
124-
assert.Nil(t, err)
125+
require.NoError(t, err)
125126
isEncoded, body, err := bodyToBase64(req)
126127

127-
assert.Equal(t, isEncoded, true)
128-
assert.Equal(t, body, expected)
129-
assert.Nil(t, err)
128+
assert.True(t, isEncoded)
129+
assert.Equal(t, expected, body)
130+
require.NoError(t, err)
130131
}

0 commit comments

Comments
 (0)