Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - ArchiSteamFarm fails to authenticate #773

Closed
JoshuaVandaele opened this issue Sep 2, 2024 · 4 comments · Fixed by #786
Closed

[BUG] - ArchiSteamFarm fails to authenticate #773

JoshuaVandaele opened this issue Sep 2, 2024 · 4 comments · Fixed by #786
Labels
bug Something isn't working

Comments

@JoshuaVandaele
Copy link

Describe the bug
My password contains special characters such as *, !, ^, @, %, ..., which the current implementation makes ArchiSteamFarm return 401.

To Reproduce
Steps to reproduce the behavior:

  1. Go add a config for ArchiSteamFarm with the correct URL and password, which contains special characters
  2. Click on "Test"
  3. See error

Expected behavior
A successfully established connection

Version info (please complete the following information):

  • Heimdall: 2.6.1
  • Docker, if applicable: lscr.io/linuxserver/heimdall:latest
  • App: ArchiSteamFarm
  • Version of remote application App tries to use: 6.0.6.4

Additional context
This is fixable by using the Authentication header instead of putting the password in the URL, this issue already happened to me in the past.

@JoshuaVandaele JoshuaVandaele added the bug Something isn't working label Sep 2, 2024
@LinuxServer-CI LinuxServer-CI moved this to Non-Docker Issues in Issue & PR Tracker Sep 2, 2024
@LinuxServer-CI
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@JoshuaVandaele
Copy link
Author

This is still an issue

@PedroBuffon
Copy link
Contributor

PedroBuffon commented Oct 3, 2024

ArchiSteamFarm on $this->config->password doesn't urlencode the password so it passes like p@ssword with the special character on the url itself, which is a big problem, i've never used ArchiSteamFarm, i can make a quick fix adding a urlencode($this->config->password) to the code parts.

@PedroBuffon
Copy link
Contributor

PR made, now just wait for the merge and test it out.

@LinuxServer-CI LinuxServer-CI moved this from Non-Docker Issues to Done in Issue & PR Tracker Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants