Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Separate Save files into Directories by System/Emulator #48

Closed
1 task done
shanez1215 opened this issue Jul 10, 2023 · 5 comments
Closed
1 task done

[FEAT] Separate Save files into Directories by System/Emulator #48

shanez1215 opened this issue Jul 10, 2023 · 5 comments

Comments

@shanez1215
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Currently, regardless of profile, all save files are dropped within the same /{profile}/saves directory. If possible, add an option to place the save files into subfolders by either emulator or system within this directory. Similar to how the roms are separated.

Current layout is
/{profile}/saves/Pokemon - Firered Version.srm
/{profile}/saves/Pokemon - Leafgreen Version.srm
/{profile}/saves/Super Mario RPG.srm

Proposed layout (at least as an option) is:
/{profile}/saves/gameboyadvance/Pokemon - Firered Version.srm
/{profile}/saves/gameboyadvance/Pokemon - Leafgreen Version.srm
/{profile}/saves/superfamicom/Super Mario RPG.srm

Reason for change

I would like to use Syncthing to sync my emulatorjs saves with the rest of my save files. My other save files are partitioned by directories as RetroNAS, RetroArch, etc are laid out like this.

However, Syncthing cannot perform two-way syncs in any many to one configuration, as it would need to know which of the many folders to send each save file type to.

As an example, with the current layout, let's say I start a game using the rom "Pokemon - Emerald Version.gba". The save file would be dropped in the {profile}/saves directory among the other saves. Thus, there's no way for syncthing to know whether to send "Pokemon - Emerald Version.srm" to the GBA save folder or the SNES save folder (or any other one).

I've poked around the source code, but I am very new with docker/emulatorjs and cannot find where these directories are declared.

Proposed code change

No response

@shanez1215 shanez1215 added the enhancement New feature or request label Jul 10, 2023
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@svenEsven
Copy link

Hopefully this gets some attention, i too would love this feature

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Dec 22, 2023
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

3 participants