react/CardStats: update stat strings to include plural versions fixes #5370 and fix tests

Author: philli-m

meinberlin/react/contrib/card/CardStats.jsx

@@ -4,9 +4,9 @@ import django from 'django'
 export const CardStats = (props) => {
   const { permissions } = props
 
-  const positiveRatingsStr = django.gettext('Likes')
-  const negativeRatingsStr = django.gettext('Dislikes')
-  const supportStr = django.gettext('Support')
+  const positiveRatingsStr = django.ngettext('Like', 'Likes', props.positiveCount)
+  const negativeRatingsStr = django.ngettext('Dislike', 'Dislikes', props.negativeCount)
+  const supportStr = django.ngettext('Supporter', 'Supporters', props.positiveCount)
   const commentsStr = django.ngettext('Comment', 'Comments', props.commentCount)
   const votesStr = django.ngettext('Vote', 'Votes', props.voteCount)
 

meinberlin/react/contrib/card/__tests__/Card.jest.jsx

@@ -64,7 +64,7 @@ test('Renders a link to item details', () => {
   expect(comments.textContent).toEqual('7CommentComments')
   // don't do same check for likes count as it also finds the
   // dislikes as non exact string but 1 count is enough
-  expect(dislikes.textContent).toEqual('1Dislikes')
+  expect(dislikes.textContent).toEqual('1DislikeDislikes')
   expect(screen.getByText('My idea')).toBeTruthy()
   expect(screen.getByText('Item details')).toBeTruthy()
 })

meinberlin/react/contrib/card/__tests__/CardStats.jest.jsx

@@ -24,7 +24,7 @@ test('2 phase: rating phase - can view comments and ratings count', () => {
   // strings constructed by ngettext will render both options as jest does not mock ngettext functionality,
   // it just returns both so we check for both as it is a predicatble outcome
   expect(comments.textContent).toEqual('18CommentComments')
-  expect(dislikes.textContent).toEqual('1Dislikes')
+  expect(dislikes.textContent).toEqual('1DislikeDislikes')
   expect(screen.queryByText('Votes')).toBeNull()
 })
 
@@ -49,7 +49,7 @@ test('3 phase: support phase - can view comments and support count', () => {
   const likes = screen.getByText('Support', { exact: false })
 
   expect(comments.textContent).toEqual('18CommentComments')
-  expect(likes.textContent).toEqual('4Support')
+  expect(likes.textContent).toEqual('4SupporterSupporters')
   expect(screen.queryByText('Dislikes')).toBeNull()
   expect(screen.queryByText('Likes')).toBeNull()
   expect(screen.queryByText('Votes')).toBeNull()

meinberlin/react/kiezkasse/__tests__/KiezkasseProposalsList.jest.jsx

@@ -52,9 +52,9 @@ test('Kiezkasse list - check render with required stats',
     expect(screen.getByText('This is a topic')).toBeTruthy()
     expect(screen.getByText('Category 1')).toBeTruthy()
     expect(screen.getByText('Label 2')).toBeTruthy()
-    expect(screen.getByText('Likes')).toBeTruthy()
+    expect(screen.getByText('LikeLikes')).toBeTruthy()
     expect(comments.textContent).toEqual('6CommentComments')
-    expect(dislikes.textContent).toEqual('1Dislikes')
+    expect(dislikes.textContent).toEqual('1DislikeDislikes')
 
     // reverse overwrite of global.fetch
     await global.fetch.mockClear()

meinberlin/react/maptopicprio/__tests__/MapTopicPrioList.jest.jsx

@@ -45,9 +45,9 @@ test('Map Topic Prioritisation list - check render with required stats',
     const dislikes = screen.getByText('Dislikes', { exact: false })
 
     expect(screen.getByText('This is a topic')).toBeTruthy()
-    expect(screen.getByText('Likes')).toBeTruthy()
+    expect(screen.getByText('LikeLikes')).toBeTruthy()
     expect(comments.textContent).toEqual('6CommentComments')
-    expect(dislikes.textContent).toEqual('1Dislikes')
+    expect(dislikes.textContent).toEqual('1DislikeDislikes')
 
     // reverse overwrite of global.fetch
     await global.fetch.mockClear()

meinberlin/react/topicprio/__tests__/TopicPrioList.jest.jsx

@@ -45,9 +45,9 @@ test('Topic Prioritisation list - check render with required stats',
     const dislikes = screen.getByText('Dislikes', { exact: false })
 
     expect(screen.getByText('This is a topic')).toBeTruthy()
-    expect(screen.getByText('Likes')).toBeTruthy()
+    expect(screen.getByText('LikeLikes')).toBeTruthy()
     expect(comments.textContent).toEqual('6CommentComments')
-    expect(dislikes.textContent).toEqual('1Dislikes')
+    expect(dislikes.textContent).toEqual('1DislikeDislikes')
 
     // reverse overwrite of global.fetch
     await global.fetch.mockClear()