Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate custom Kiezradar deleteModal into a4 #6004

Open
4 tasks
hom3mad3 opened this issue Jan 29, 2025 · 4 comments
Open
4 tasks

Integrate custom Kiezradar deleteModal into a4 #6004

hom3mad3 opened this issue Jan 29, 2025 · 4 comments
Labels
Dev: A4 depending PR or issue dependent on A4 Prio: Low fix when there is time

Comments

@hom3mad3
Copy link
Contributor

hom3mad3 commented Jan 29, 2025

Description:
A new delete modal has been introduced in PR #6002 (update: refactored here). To avoid functionality duplication and ensure reusability, it should be integrated into the global Modal.jsx component in the A4 codebase.

Expected Outcome:

  • The delete modal should be part of the global Modal.jsx.
  • Ensure that it can be reused wherever necessary across the application.

Tasks:

  • Review the current delete modal implementation from PR [#8813] Add kiezradar delete modal #6002.
  • Refactor the delete modal code using the global Modal.jsx component in a4 (like ReportModal.jsx etc).
  • Delete instances of deleteModal and custom styles (instead use a4-modal.scss)
  • Ensure existing modal functionalities are preserved and consistent.

Additional Notes:

  • Check for potential conflicts with existing modal usages.
  • Confirm that UI/UX remains consistent post-integration.
@hom3mad3 hom3mad3 added Dev: A4 depending PR or issue dependent on A4 Prio: Low fix when there is time Prio: Medium fixed and released with next scheduled release and removed Prio: Low fix when there is time labels Jan 29, 2025
@CarolingerSeilchenspringer
Copy link
Contributor

@hom3mad3 if you say this is low prio, can it be done after release? If not, please add to milestone "fix before re-launch"

@hom3mad3
Copy link
Contributor Author

@CarolingerSeilchenspringer it can be done after release, but i moved to medium since it's important nonetheless

@CarolingerSeilchenspringer CarolingerSeilchenspringer added Prio: Low fix when there is time and removed Prio: Medium fixed and released with next scheduled release labels Jan 30, 2025
@CarolingerSeilchenspringer
Copy link
Contributor

@hom3mad3 our definition of medium is to be fixed before next release, so I put to low but into the milestone that we will check after release. :-)

@hom3mad3
Copy link
Contributor Author

@hom3mad3 our definition of medium is to be fixed before next release, so I put to low but into the milestone that we will check after release. :-)

ok, i wasn't aware of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: A4 depending PR or issue dependent on A4 Prio: Low fix when there is time
Projects
None yet
Development

No branches or pull requests

2 participants