Skip to content

Commit 8cd97b6

Browse files
committed
app: Move sql_internal.c into its own object
It needs to be included in the sheet command for the pivot builtin and in the sql command.
1 parent 417e27d commit 8cd97b6

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

app/Makefile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,8 @@ SQLITE_SRC=${THIS_MAKEFILE_DIR}/external/sqlite3/sqlite3*.c
285285
SQLITE_EXT=${BUILD_DIR}-external/sqlite3/sqlite3_and_csv_vtab.o
286286
SQLITE_EXT_INCLUDE=-I${THIS_MAKEFILE_DIR}/external/sqlite3
287287

288+
SQL_INTERNAL_OBJECT=${CLI_OBJ_PFX}sql_internal.o
289+
288290
# everything uses prop, which in turn uses yajl and jq and json and sqlite3
289291
OBJECTS+= ${YAJL_OBJ} ${YAJL_HELPER_OBJ} ${BUILD_DIR}/objs/utils/json.o ${SQLITE_EXT}
290292
MORE_SOURCE+= ${YAJL_INCLUDE} ${YAJL_HELPER_INCLUDE} -I${JQ_INCLUDE_DIR} ${SQLITE_EXT_INCLUDE}
@@ -395,12 +397,16 @@ ${INIH_OBJECT}: ${INIH_SRC}/ini.c
395397
@mkdir -p `dirname "$@"`
396398
${CC} ${CFLAGS} -I${INIH_INCLUDE} -DINI_HANDLER_LINENO=1 -DINI_CALL_HANDLER_ON_NEW_SECTION=1 -c $< -o $@
397399

400+
${SQL_INTERNAL_OBJECT}: ${CLI_OBJ_PFX}%.o: %.c %.h
401+
@mkdir -p `dirname "$@"`
402+
${CC} ${CFLAGS} -I${INCLUDE_DIR} -c -o $@ $<
403+
398404
${CLI_APP_OBJECT} : cli_ini.c builtin/*.c ${JQ_LIB}
399405
${CLI_APP_OBJECT} ${CLI_OBJECTS}: ${CLI_OBJ_PFX}%.o: %.c ${UTF8PROC_SRC}/utf8proc.c # ${MORE_OBJECTS}
400406
@mkdir -p `dirname "$@"`
401407
${CC} ${CFLAGS} -DVERSION=\"${VERSION}\" -DZSV_CLI ${CLI_INCLUDE} -I${THIS_MAKEFILE_DIR}/external/sglib -I${INCLUDE_DIR} -I${UTF8PROC_INCLUDE} -c $< -o $@ ${MORE_SOURCE}
402408

403-
${CLI}: cli_internal.c.in cli_internal.h cli_internal.h.in ${CLI_APP_OBJECT} ${CLI_OBJECTS} ${OBJECTS} ${UTF8PROC_OBJECT} cli_ini.c ${INIH_OBJECT} ${LIBZSV_INSTALL} ${MORE_OBJECTS}
409+
${CLI}: cli_internal.c.in cli_internal.h cli_internal.h.in ${CLI_APP_OBJECT} ${CLI_OBJECTS} ${OBJECTS} ${UTF8PROC_OBJECT} cli_ini.c ${INIH_OBJECT} ${LIBZSV_INSTALL} ${MORE_OBJECTS} ${SQL_INTERNAL_OBJECT}
404410
@mkdir -p `dirname "$@"`
405411
${CC} ${CFLAGS} ${CFLAGS_EXE} -I${INCLUDE_DIR} -o $@ ${CLI_APP_OBJECT} ${CLI_OBJECTS} ${OBJECTS} ${UTF8PROC_OBJECT} ${INIH_OBJECT} -L${LIBDIR} ${LIBZSV_L} ${LDFLAGS} ${LDFLAGS_OPT} ${MORE_OBJECTS} ${MORE_SOURCE} ${MORE_LIBS} ${STATIC_LIB_FLAGS}
406412
@echo Built $@
@@ -465,6 +471,7 @@ ${CLI} ${STANDALONE_PFX}2json${EXE}: MORE_OBJECTS+= ${BUILD_DIR}/objs/utils/db.o
465471
# pretty uses termcap
466472
${CLI} ${STANDALONE_PFX}pretty${EXE}: MORE_LIBS+=${LDFLAGS_TERMCAP}
467473

474+
${CLI} ${STANDALONE_PFX}sheet${EXE} ${STANDALONE_PFX}sql${EXE}: MORE_OBJECTS+=${SQL_INTERNAL_OBJECT}
468475

469476
${STANDALONE_PFX}%${EXE}: %.c ${OBJECTS} ${MORE_OBJECTS} ${LIBZSV_INSTALL} ${UTF8PROC_OBJECT}
470477
@mkdir -p `dirname "$@"`

app/sql.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
#include <zsv/utils/writer.h>
2020
#include <zsv/utils/file.h>
2121
#include <zsv/utils/string.h>
22+
#include <zsv/utils/sql.h>
23+
#include "sql_internal.h"
2224

2325
#include <unistd.h> // unlink
2426

@@ -109,8 +111,6 @@ static char is_select_sql(const char *s) {
109111
(const unsigned char *)s, strlen("select "));
110112
}
111113

112-
#include "sql_internal.c"
113-
114114
int ZSV_MAIN_FUNC(ZSV_COMMAND)(int argc, const char *argv[], struct zsv_opts *opts,
115115
struct zsv_prop_handler *custom_prop_handler) {
116116
/**

0 commit comments

Comments
 (0)