Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when downloaded from gallery, data files always receive extension csv #119

Open
ghost opened this issue Mar 3, 2017 · 5 comments
Open
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Mar 3, 2017

In reality, people may be uploading xlsx or other files. Extensions should not be renamed when downloading the files

@liside
Copy link
Owner

liside commented Mar 3, 2017

Well, the file has to be a csv. After they upload the file, the file will lose its extension so I need to rename it

@izaslavsky
Copy link
Collaborator

but the initial extension still shows in the gallery, as part of the file name?

@liside
Copy link
Owner

liside commented Mar 3, 2017

Renaming is meant to manage datasets, since users may have the same name for their datasets. If you want to keep it, we can keep it

@izaslavsky
Copy link
Collaborator

I think it would make more sense to rename things into dataset.csv, dataset_01.csv, dataset_02.csv, rather than changing extensions. When users see that it is an xsls file in the gallery (which is common for people who just started - and upload incorrect formats), click on it to download, get a csv file (while it is actually xlsx), try to open it as a csv, and get an error - we shall try to avoid this. When they upload a xlsx in the first place, the authoring should tell them that at this point only csv files are accepted

@liside
Copy link
Owner

liside commented Mar 4, 2017

I added a check block that stops users from uploading anything other than csv files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants