Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error details in synchronous DI responses #1928

Closed
Tracked by #1920
Kailai-Wang opened this issue Jul 23, 2023 · 0 comments · Fixed by #1957
Closed
Tracked by #1920

Display error details in synchronous DI responses #1928

Kailai-Wang opened this issue Jul 23, 2023 · 0 comments · Fixed by #1957
Assignees
@kziemianek
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I3-high should be completed within 5 working days

Comments

@Kailai-Wang
Copy link
Collaborator

Kailai-Wang commented Jul 23, 2023 •
edited
Loading

Context

Follow-up of #1883.

Once #1920 gets merged, we should further adjust the error handling to include it in the DI responses, preferably in the value field: hex string of encoded error type. See also the comment in trusted_call.rs.

It should be at least tested via DI-sample.

✔️ Please set appropriate labels and assignees if applicable.
@Kailai-Wang Kailai-Wang added I3-high should be completed within 5 working days D1-feature A new feature, a piece of functionality that needs to be developed labels Jul 23, 2023
@Kailai-Wang Kailai-Wang mentioned this issue Jul 23, 2023
Merged
2 tasks
@kziemianek kziemianek mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kziemianek kziemianek

Labels
D1-feature A new feature, a piece of functionality that needs to be developed I3-high should be completed within 5 working days
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DI error responses litentry/litentry-parachain
2 participants
@kziemianek @Kailai-Wang