fix(internal): error while installing deps with tag

fenying · fenying · commit 6feff4afd8e1 · 2020-09-10T17:23:01.000+08:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@
 
 - fix(cmd:install): did not save development dependencies to devDependencies.
 - fix(internal): error while reading omitted deps fields.
+- fix(internal): error while installing deps with tag.
 - feat(cmd:release): execute "ottoia:clean" before publish.
 - feat(cmd:release): added "--version" option to specify the target version.
 - feat(cmd:release): added hook "ottoia:prepare" between "ottoia:prepublish" and "npm publish".
diff --git a/src/lib/_internal/PackageUtils.ts b/src/lib/_internal/PackageUtils.ts
@@ -44,9 +44,11 @@ class PackageUtils implements I.IPackageUtils {
         return validateNPMPackageName(name).validForNewPackages;
     }
 
-    public isValidDependencyName(name: string): boolean {
+    public isValidDependencyName(expr: string): boolean {
 
-        return validateNPMPackageName(name).validForOldPackages;
+        const [name, tag] = expr.split(/(?!^)@/, 2);
+
+        return validateNPMPackageName(name).validForOldPackages && /^[a-z0-9]+$/.test(tag);
     }
 
     public validatePackageName(name: string): void {

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,11 @@ class PackageUtils implements I.IPackageUtils {`
`44`	`44`	`return validateNPMPackageName(name).validForNewPackages;`
`45`	`45`	`}`
`46`	`46`
`47`		`- public isValidDependencyName(name: string): boolean {`
	`47`	`+ public isValidDependencyName(expr: string): boolean {`
`48`	`48`
`49`		`- return validateNPMPackageName(name).validForOldPackages;`
	`49`	`+ const [name, tag] = expr.split(/(?!^)@/, 2);`
	`50`	`+`
	`51`	`+ return validateNPMPackageName(name).validForOldPackages && /^[a-z0-9]+$/.test(tag);`
`50`	`52`	`}`
`51`	`53`
`52`	`54`	`public validatePackageName(name: string): void {`