lab004/firmware: fix firmware build #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two separate issues that were keeping lab004 from working. The first is a minor but important oversight from litex-hub@b36c77a: It added a definition for crt0.o but then didn't refer to it anywhere, effectively removing crt0.o from the build. That was likely the cause of litex-hub#12. The second issue I don't understand as well, but seems to be exactly the same as enjoy-digital/litex#1007, from which I copied the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two separate issues that were keeping lab004 from working.
The first is a minor but important oversight from b36c77a: It added a definition for crt0.o but then didn't refer to it anywhere, effectively removing crt0.o from the build.
That was likely the cause of #12.
The second issue I don't understand as well, but seems to be exactly the same as enjoy-digital/litex#1007, from which I copied the fix.
Before these fixes, lab004 was failing for me in the same way as described in #12 (and #11). After these fixes, it is working.
Resolves #12