check chrome failure type (#678)

* check chrome failure type

* avoid unknown

* fix imports

Author: frostbyte73

pkg/errors/errors.go

@@ -104,6 +104,10 @@ var (
 	ErrShuttingDown               = psrpc.NewErrorf(psrpc.Unavailable, "server is shutting down")
 )
 
+func ErrPageLoadFailed(err string) error {
+	return psrpc.NewErrorf(psrpc.InvalidArgument, "template page load failed: %s", err)
+}
+
 func ErrCouldNotParseConfig(err error) error {
 	return psrpc.NewErrorf(psrpc.InvalidArgument, "could not parse config: %v", err)
 }

pkg/info/info.go

@@ -49,9 +49,10 @@ func (e *EgressInfo) SetFailed(err error) {
 	e.Error = err.Error()
 	var perr psrpc.Error
 	if errors.As(err, &perr) {
-		e.ErrorCode = int32(perr.ToHttp())
-	} else {
-		e.ErrorCode = int32(http.StatusInternalServerError)
+		// unknown is treated the same as an internal error (500)
+		if !errors.Is(perr.Code(), psrpc.Unknown) {
+			e.ErrorCode = int32(perr.ToHttp())
+		}
 	}
 }
 

pkg/pipeline/source/web.go

@@ -38,6 +38,8 @@ import (
 const (
 	startRecordingLog = "START_RECORDING"
 	endRecordingLog   = "END_RECORDING"
+
+	chromeFailedToStart = "chrome failed to start:"
 )
 
 type WebSource struct {
@@ -314,11 +316,15 @@ func (s *WebSource) launchChrome(ctx context.Context, p *config.PipelineConfig,
 		),
 	)
 	if err != nil {
-		return errors.ErrProcessStartFailed(err)
+		if strings.HasPrefix(err.Error(), chromeFailedToStart) {
+			return errors.ErrProcessStartFailed(err)
+		}
+		errString = err.Error()
 	}
 	if errString != "" {
-		return errors.New(errString)
+		return errors.ErrPageLoadFailed(errString)
 	}
+
 	return nil
 }