Commit 3371abd
feat(rtc): Add event_types filtering to FfiQueue.subscribe()
PROBLEM:
FfiQueue.put() broadcasts ALL FFI events to ALL subscribers via
call_soon_threadsafe(). Each call creates asyncio.Handle + context objects.
AudioStream/VideoStream filter events with wait_for(predicate), but objects
are already allocated. With N streams, this creates N × all_events objects,
with 95%+ discarded after allocation.
In a 2-hour meeting with 4 participants, we observed:
- 903,154 FFI events accumulated
- Memory grew from 312 MB to 1.29 GB
- Event loop lag increased to 20+ seconds
SOLUTION:
Add optional `event_types` parameter to FfiQueue.subscribe(). When specified,
events are filtered by type BEFORE calling call_soon_threadsafe(), preventing
unnecessary object allocation.
AudioStream now subscribes with event_types={"audio_stream_event"}
VideoStream now subscribes with event_types={"video_stream_event"}
This reduces memory allocations by ~95% for stream subscribers while
maintaining full backwards compatibility (event_types=None = all events).
TESTING:
- Added unit tests for event filtering functionality
- Verified 95% reduction in object creation with filtered subscribers
- Tested in production environment with stable memory usage
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent 2744c66 commit 3371abd
File tree
4 files changed
+375
-8
lines changed- livekit-rtc/livekit/rtc
- tests/rtc
4 files changed
+375
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
99 | 102 | | |
100 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
101 | 111 | | |
102 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
103 | 118 | | |
104 | 119 | | |
105 | 120 | | |
106 | 121 | | |
107 | 122 | | |
108 | 123 | | |
109 | 124 | | |
110 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
111 | 140 | | |
112 | 141 | | |
113 | 142 | | |
114 | | - | |
| 143 | + | |
115 | 144 | | |
116 | 145 | | |
117 | 146 | | |
118 | 147 | | |
119 | 148 | | |
120 | | - | |
| 149 | + | |
121 | 150 | | |
122 | 151 | | |
123 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
| |||
0 commit comments