Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create ParticipantSid from String in user module #250

Closed
trzeciak opened this issue Nov 29, 2023 · 1 comment
Closed

Allow to create ParticipantSid from String in user module #250

trzeciak opened this issue Nov 29, 2023 · 1 comment

Comments

@trzeciak
Copy link
Contributor

Hey, I want test/use this livekit-rust-sdk in c++ code.
To do this I create internal-rust-layer to expose some functionality, and extract it to c++.
I came across a problem to create ParticipantSid from String in user module,
therefore i purpose to add 'pub' in declaration of this type:

pub struct ParticipantSid(String);
pub struct ParticipantSid(pub String);

Do you think it is ok, or I should choose other way?

trzeciak added a commit to explaineverything/rust-sdks that referenced this issue Nov 29, 2023
@theomonnom
Copy link
Member

Answered in #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants