-
Notifications
You must be signed in to change notification settings - Fork 2
Svelte5 upgrade #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
TODO: Doesn't bundle scoped styles for now. Got to fix it.
It is easier to manipulate and check these values, when they are strings. E.g. A number cannot be empty (if it is, it has to be set undefined)
|
Hello @HighPriest , this is awesome 😎 , thank you so much for the contribution, and i'm sorry for the late reply, i was on vacations. Will take a look at your PR today and merge it tomorrow for sure. Once again thank you very much for contributing! |
|
Please wait for me to finish noted maintenance. I might be able to do it today, or I'll finish it aln tomorrow. Big thanks to @brenoliradev for figuring out how to make reliable standalone builds of Svelte 5 |
|
@osousa |
|
Hey - I think you don't need to worry with your TODO --production flag since you're using css on .svelte. Svelte actually purges all unused css by default so you should be fine =) Let me know how it goes. |
|
Hey @brenoliradev I've just tested this PR on mobile and here are bugs that are still in the code:
Mind that I am using Cromite in incognito mode for these tests. But using a browser with most permissions disabled by default, shouldn't break the app. |
Hi @osousa
I wanted to iterate on your creation for some time now and I finally got to re-writing the front-end application, matching it to standards of Svelte 5.
There are still quite a few things to do, so here is a WIP to bring attention to things happening.
TODO:
Extra features: