FDB-101: remove code warnings

lk-code · lk-code · commit 80ba4970942a · 2025-01-30T17:03:54.000+01:00
diff --git a/source/FluentDataBuilder.Json/DataBuilderExtensions.cs b/source/FluentDataBuilder.Json/DataBuilderExtensions.cs
@@ -158,7 +158,6 @@ private static IDataBuilder ConvertToIDataBuilder(IDataBuilder builder, string k
 
                 throw new ArgumentOutOfRangeException($"unknown numeric data type: {jsonElement.ValueKind}");
             }
-                break;
             case JsonValueKind.True:
                 return true;
             case JsonValueKind.False:
diff --git a/source/FluentDataBuilder/Helper/DictionaryExtensions.cs b/source/FluentDataBuilder/Helper/DictionaryExtensions.cs
@@ -28,7 +28,7 @@ public static class DictionaryExtensions
                     mergedDictionary[key] = value;
                 }
             }
-            else if (value is Dictionary<string, object> dictionaryValue)
+            else if (value is Dictionary<string, object?> dictionaryValue)
             {
                 if (mergedDictionary[key] is Dictionary<string, object?> leftDictionaryValue)
                 {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,6 @@ private static IDataBuilder ConvertToIDataBuilder(IDataBuilder builder, string k`
`158`	`158`
`159`	`159`	`throw new ArgumentOutOfRangeException($"unknown numeric data type: {jsonElement.ValueKind}");`
`160`	`160`	`}`
`161`		`- break;`
`162`	`161`	`case JsonValueKind.True:`
`163`	`162`	`return true;`
`164`	`163`	`case JsonValueKind.False:`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public static class DictionaryExtensions`
`28`	`28`	`mergedDictionary[key] = value;`
`29`	`29`	`}`
`30`	`30`	`}`
`31`		`- else if (value is Dictionary<string, object> dictionaryValue)`
	`31`	`+ else if (value is Dictionary<string, object?> dictionaryValue)`
`32`	`32`	`{`
`33`	`33`	`if (mergedDictionary[key] is Dictionary<string, object?> leftDictionaryValue)`
`34`	`34`	`{`