Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review #2

Open
arosemond1 opened this issue Apr 9, 2022 · 0 comments
Open

Peer Review #2

arosemond1 opened this issue Apr 9, 2022 · 0 comments

Comments

@arosemond1
Copy link

HTML Recommendation

  1. After running the homepage through a validator, a quick formatting issue in your HTML was using "" instead of "/" in your reference to the image. For example, line 188 on homepage.html:
    <img src="images\ChelseaChampionsLeague.jpg" alt="aboutchelsea" />
  2. Another recommendation is consolidating the home page and home buttons. You currently have a button for both a home and home page on your navbar, and the "Home Page" link does not work. Potentially, getting rid of this link or replacing it with a link to the index could improve your code.

Content Recommendation

  1. My first recommendation is to resize some of the images to display the image better and improve the website's look.
  2. My second recommendation is to add some borders to the table of players on the squad.html to make the individual player information easier to distinguish and add more columns so that the table is taking up some more space on the page. (ex. Player 1-10 in 1 column, and Player11-20 in another)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant