Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Commit Access For ofri-frishman #127235

Open
ofri-frishman opened this issue Feb 14, 2025 · 5 comments
Open

Request Commit Access For ofri-frishman #127235

ofri-frishman opened this issue Feb 14, 2025 · 5 comments

Comments

@ofri-frishman
Copy link
Contributor

Hi,
I have been working for a while on an MLIR downstream project at Mobileye, with several other team members that have commit access.
Recently I have been working on a PR for the upstream project and thus need commit access to land it once it is approved.
Another issue - I don't seem to be able to add reviewers to the PR, will that be changed once I am granted commit access or does that require a different permission? and if it does, how do I request such permission?
Thanks,
Ofri Frishman

Copy link

@ofri-frishman thank you for applying for commit access. Please review the project's code review policy.

@llvmbot
Copy link
Member

llvmbot commented Feb 14, 2025

@llvm/issue-subscribers-infra-commit-access-request

Author: ofri frishman (ofri-frishman)

Hi, I have been working for a while on an MLIR downstream project at Mobileye, with several other team members that have commit access. Recently [I have been working on a PR](https://github.com//pull/126898) for the upstream project and thus need commit access to land it once it is approved. Another issue - I don't seem to be able to add reviewers to the PR, will that be changed once I am granted commit access or does that require a different permission? and if it does, how do I request such permission? Thanks, Ofri Frishman

Copy link

Activity Summary:

@banach-space
Copy link
Contributor

@ofri-frishman , please note #127006.

Also,

thus need commit access to land it once it is approved

That's not really required. One of the reviewers can merge it for you.

I don't seem to be able to add reviewers to the PR

For most parts of the code, reviewers are added "auto-magically". If you'd like a specific person to review your code, you can ping them in a comment. In my experience, most active people respond almost immediately.

@ofri-frishman
Copy link
Contributor Author

@ofri-frishman , please note #127006.

Also,

thus need commit access to land it once it is approved

That's not really required. One of the reviewers can merge it for you.

I don't seem to be able to add reviewers to the PR

For most parts of the code, reviewers are added "auto-magically". If you'd like a specific person to review your code, you can ping them in a comment. In my experience, most active people respond almost immediately.

Thanks for the link and clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants