Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality improvement #3

Open
3 of 5 tasks
lmmx opened this issue Jul 9, 2021 · 2 comments
Open
3 of 5 tasks

Code quality improvement #3

lmmx opened this issue Jul 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@lmmx
Copy link
Owner

lmmx commented Jul 9, 2021 •
edited
Loading

Pre-commit is running a few standard checks, further improvement could be gained from:

  • pylint
    • code
    • tests
      • remaining problems are ignorable
    • (not sure if this needs to be in CI tbh, just run when looking to edit)
  • tryceratops
  • TODO: investigate flake8/other options
@lmmx lmmx added the enhancement New feature or request label Jul 9, 2021
@lmmx
Copy link
Owner Author

lmmx commented Jul 11, 2021

For example with flake8 see mcx: .github/workflows/lint.yml and Makefile

@lmmx
Copy link
Owner Author

lmmx commented Jul 28, 2021

I would also suggest adding an automated check for the maintenance of full docstring coverage (#13: now achieved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmmx