Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix to Zstd tar codec #34

Open
lmmx opened this issue Aug 9, 2021 · 0 comments
Open

Suggested fix to Zstd tar codec #34

lmmx opened this issue Aug 9, 2021 · 0 comments

Comments

@lmmx
Copy link
Owner

lmmx commented Aug 9, 2021

Comment from Ma Lin: ae185f9#r54497564

I search pyzstd on GitHub (I'm the author of it), then I found this code.

The .close() method was updated. If super().close() fails, .zstd_file can be closed at once.
This is a very minor fix.

            def close(self):
                try:
                    super().close()
                finally:
                    self.zstd_file.close()

in reference to

def close(self): # pragma: no cover
super().close()
self.zstd_file.close()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant