[CHORE] update market binaries #107
Conversation
| } | ||
| } | ||
|
|
||
| function productCompare(a, b, sortBy, sortOrder) { |
There was a problem hiding this comment.
I didn't modify anything.
looks like it was done in lnbits/nostr-market-app#11
|
hey, been traveling a bit so just getting back to check this out. Still a bit of a newb when it comes to properly handling PR's, as you can see... I see I should have tested it out in the context of running in lnbits and not stand-alone for the paths! Let me know if there is anything I can do to help finish up the PR. |
… safe part of new build
|
okay so this has been a learning experience 😅 when building nostr-market-app it's necessary to change the following in publicPath: "/nostrmarket/static/market",
// publicPath: "/", framework: {
config: { staticPath: "/nostrmarket/static/market/" },
// config: { staticPath: "" },so that it builds correctly in the context of running inside lnbits. At first I just went in and manually added the paths, but then I don't know if the build names the files, e.g., Tested it out a bit, gonna test some more, but otherwise should be pretty good to go! |
these have not been updated since 2023-09-21
since then there has been the following PR's:
Closes #102