fix: properly start/stop tasks (#8)

lnbits/lnbits#2411

Author: dni

__init__.py

@@ -1,16 +1,14 @@
 import asyncio
-from typing import List
+from loguru import logger
 
 from fastapi import APIRouter
 
 from lnbits.db import Database
 from lnbits.helpers import template_renderer
-from lnbits.tasks import catch_everything_and_restart
+from lnbits.tasks import create_permanent_unique_task
 
 db = Database("ext_scrub")
 
-scheduled_tasks: List[asyncio.Task] = []
-
 scrub_static_files = [
     {
         "path": "/scrub/static",
@@ -30,7 +28,15 @@ def scrub_renderer():
 from .views_api import *  # noqa: F401,F403
 
 
+scheduled_tasks: list[asyncio.Task] = []
+
+def scrub_stop():
+    for task in scheduled_tasks:
+        try:
+            task.cancel()
+        except Exception as ex:
+            logger.warning(ex)
+
 def scrub_start():
-    loop = asyncio.get_event_loop()
-    task = loop.create_task(catch_everything_and_restart(wait_for_paid_invoices))
+    task = create_permanent_unique_task("ext_scrub", wait_for_paid_invoices)
     scheduled_tasks.append(task)

views_api.py

@@ -12,7 +12,7 @@
     require_admin_key,
 )
 
-from . import scheduled_tasks, scrub_ext
+from . import scrub_ext
 from .crud import (
     create_scrub_link,
     delete_scrub_link,
@@ -111,14 +111,3 @@ async def api_link_delete(link_id, wallet: WalletTypeInfo = Depends(require_admi
 
     await delete_scrub_link(link_id)
     return "", HTTPStatus.NO_CONTENT
-
-
-@scrub_ext.delete("/api/v1", status_code=HTTPStatus.OK, dependencies=[Depends(check_admin)])
-async def api_stop():
-    for t in scheduled_tasks:
-        try:
-            t.cancel()
-        except Exception as ex:
-            logger.warning(ex)
-
-    return {"success": True}