Conversation
wip WIP Assignments
anisaoshafi
approved these changes
Sep 16, 2025
Collaborator
There was a problem hiding this comment.
Amazing work Cristian, impressive how you could keep all the thoughts in order while making these code changes 👏🏼 thank you for improving the cli detection!
I tried to understand the highlight changes, and didn't notice anything fishy.
I'll leave it to @tiurin for another pair of eyes 👀
Co-authored-by: Anisa Oshafi <anisaoshafi@gmail.com>
It is confusing that time stamp variables end with status tracker because there are many more actual status trackers defined alongside. Renaming to make it clear these ones are about time.
… license check If there is no valid CLI path at this point then something wrong happened to CLI _between_ CLI installation step and license check, otherwise setup would have exited before. This is unlikely situation that would probably only happen if the user or any other 3rd party program tampers with localstack installation while authentication work is happening in the step before. However, it's a good idea to add two buttons to re-run the wizard and show logs! Added both. Also adds telemetry `setup_ended` event with failed state. In this case we can't really say that license check has failed because the setup didn't get to it yet. However, overall the setup has failed even if any individual step has not, therefore the event says so, thus indicating a possibility of an external error.
tiurin
approved these changes
Sep 18, 2025
Collaborator
tiurin
left a comment
tiurin
left a comment
There was a problem hiding this comment.
@skyrpex @anisaoshafi I've pushed several commits with fixes and update according to previous reviews. Hard to say now who should approve the PR now, we all contributed! 😄 🎉
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Creates a function that calls the given callback immediately once. | |||
| * Creates a function that calls the given callback on the next tick, once per tick. | |||
Collaborator
There was a problem hiding this comment.
Thanks for adding the explainer @skyrpex! Naming is admittedly very confusing 😄
tiurin
added a commit
that referenced
this pull request
Oct 7, 2025
tiurin
added a commit
that referenced
this pull request
Oct 8, 2025
Reverts #60 Step 2 in bringing main back to the state before #60 that introduced a regression. Changes from #60 are to be reapplied in a different manner to prevent the regression. This bring `main` to a releaseable state again. Note: step 1 is #64, had to be reverted as well because its changes were made on top of #60 ones and cannot be isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the CLI detection in favor of an event-based status tracker. This improves performance as we don't require periodic checks anymore.
In addition, it detects existing outdated LocalStack CLI versions (versions <= 4) and offers to run the setup wizard.
Finally, some rudimentary tests for the LocalStack Instance status tracker were added.