Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist sequence opened in modal in URL #2025

Open
chaoran-chen opened this issue May 27, 2024 · 1 comment
Open

Persist sequence opened in modal in URL #2025

chaoran-chen opened this issue May 27, 2024 · 1 comment
Labels
feature Feature proposal website Tasks related to the web application

Comments

@chaoran-chen
Copy link
Member

Related to #2024, I think that it would be very useful to persist the sequence entry ID in the URL when it is opened in a modal on the browse page. This would make it easier for people to send a link to an entry (now, you have to first open it in a new tab and not every user will know that). Further, it will re-open the same entry if the page is reloaded (which one might do on purpose but also, for example, upon restart of a browser).

@chaoran-chen chaoran-chen added the website Tasks related to the web application label May 27, 2024
@chaoran-chen chaoran-chen added this to the MVP (nice to have) milestone May 27, 2024
@theosanderson
Copy link
Member

We can definitely do this. It gets into a slightly confusing state where there is the potential for the modalised sequence to no longer be visible on the search page, because the search results have changed. If we have for example left and right arrow keys to swap between what is displayed in the modal, then it's not clear what they should do in that case (probably nothing) - but that's not a huge deal.

@chaoran-chen chaoran-chen added the feature Feature proposal label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature proposal website Tasks related to the web application
Projects
Status: Backlog
Development

No branches or pull requests

2 participants