Added check for max docs per folder

Author: car031

logicaldoc-core/src/main/java/com/logicaldoc/core/document/HibernateDocumentDAO.java

@@ -304,6 +304,16 @@ public void store(Document doc, final DocumentHistory transaction) throws Persis
 				log.debug("Aspect customId is disabled so force the the Custom ID to a random UUID");
 			}
 
+			/*
+			 * Check maximum number of documents per folder
+			 */
+			long maxDocsPerFolder = config.getLong("maxdocsperfolder", -1L);
+			if (doc.getId() == 0L && maxDocsPerFolder > 0) {
+				long count = folderDAO.countDocs(doc.getFolder().getId());
+				if (count >= maxDocsPerFolder)
+					throw new TooManyDocumentsException(doc.getFolder(), maxDocsPerFolder);
+			}
+
 			log.debug("Invoke listeners before store");
 			Map<String, Object> dictionary = new HashMap<>();
 			for (DocumentListener listener : listenerManager.getListeners())

logicaldoc-core/src/main/java/com/logicaldoc/core/document/TooManyDocumentsException.java

@@ -0,0 +1,27 @@
+package com.logicaldoc.core.document;
+
+import com.logicaldoc.core.PersistenceException;
+import com.logicaldoc.core.folder.Folder;
+
+/**
+ * Exception raised when you try to add more documents than allowed in the same
+ * folder
+ * 
+ * @author Marco Meschieri - LogicalDOC
+ * @since 9.1.1
+ */
+public class TooManyDocumentsException extends PersistenceException {
+	private static final long serialVersionUID = 1L;
+
+	private final long folderId;
+
+	public TooManyDocumentsException(Folder folder, long max) {
+		super(String.format("Folder %s (%d) cannot exceed the limit of %d documents configured in the settings",
+				folder.getName(), folder.getId(), max));
+		this.folderId = folder.getId();
+	}
+
+	public long getFolderId() {
+		return folderId;
+	}
+}

logicaldoc-core/src/main/java/com/logicaldoc/core/folder/FolderDAO.java

@@ -53,7 +53,8 @@ public interface FolderDAO extends PersistentObjectDAO<Folder> {
 	 * 
 	 * @throws PersistenceException error at data layer
 	 */
-	public List<Folder> findByName(Folder parent, String name, Long tenantId, boolean caseSensitive) throws PersistenceException;
+	public List<Folder> findByName(Folder parent, String name, Long tenantId, boolean caseSensitive)
+			throws PersistenceException;
 
 	/**
 	 * Retrieves the root folder of the given tenant
@@ -207,7 +208,7 @@ public Collection<Long> findFolderIdByUserIdAndPermission(long userId, Permissio
 	 * 
 	 * @return List of found folders
 	 * 
-	 * @throws PersistenceException Error in the database 
+	 * @throws PersistenceException Error in the database
 	 */
 	public List<Folder> findChildren(long parentId, Integer max) throws PersistenceException;
 
@@ -243,12 +244,12 @@ public Collection<Long> findFolderIdByUserIdAndPermission(long userId, Permissio
 	 * 
 	 * @return if the user has write permission
 	 * 
-	 * @throws PersistenceException error at data layer 
+	 * @throws PersistenceException error at data layer
 	 */
 	public boolean hasWriteAccess(Folder folder, long userId) throws PersistenceException;
-	
+
 	public boolean isReadAllowed(long folderId, long userId) throws PersistenceException;
-	
+
 	public boolean isPreviewAllowed(long folderId, long userId) throws PersistenceException;
 
 	public boolean isPrintAllowed(long folderId, long userId) throws PersistenceException;
@@ -293,7 +294,7 @@ public Collection<Long> findFolderIdByUserIdAndPermission(long userId, Permissio
 	 * 
 	 * @return List of selected folder ID's.
 	 * 
-	 * @throws PersistenceException error at data layer  
+	 * @throws PersistenceException error at data layer
 	 */
 	public List<Long> findIdByUserId(long userId, long parentId) throws PersistenceException;
 
@@ -304,7 +305,7 @@ public Collection<Long> findFolderIdByUserIdAndPermission(long userId, Permissio
 	 * 
 	 * @return The List of folders
 	 * 
-	 * @throws PersistenceException error at data layer 
+	 * @throws PersistenceException error at data layer
 	 */
 	public List<Folder> findByGroupId(long groupId) throws PersistenceException;
 
@@ -647,7 +648,7 @@ public Folder copy(Folder source, Folder target, String newName, boolean folders
 	 * 
 	 * @return True if the folder with the given parentId is parent of the
 	 *         folder with the given childId
-	 *         
+	 * 
 	 * @throws PersistenceException error at data layer
 	 */
 	public boolean isInPath(long parentId, long childId) throws PersistenceException;
@@ -774,6 +775,15 @@ public void updateSecurityRef(long folderId, long rightsFolderId, FolderHistory
 	 */
 	public long countDocsInTree(long rootId);
 
+	/**
+	 * Counts the number of documents inside a given folder
+	 * 
+	 * @param folderId identifier of the folder
+	 * 
+	 * @return the number of documents contained in the folder
+	 */
+	public long countDocs(long folderId);
+
 	/**
 	 * Counts the number of documents inside a given folder's tree (direct and
 	 * indirect children)

logicaldoc-core/src/main/java/com/logicaldoc/core/folder/HibernateFolderDAO.java

@@ -2015,7 +2015,18 @@ public long countDocsInTree(long rootId) {
 			return 0;
 		}
 	}
-
+	
+	@Override
+	public long countDocs(long folderId) {
+		try {
+			Folder folder= findFolder(folderId);
+			return queryForLong("SELECT COUNT(*) from ld_document WHERE ld_deleted=0 and ld_folderid="+folder.getId());
+		} catch (PersistenceException e) {
+			log.error(e.getMessage(), e);
+			return 0;
+		}
+	}
+	
 	@Override
 	public long computeTreeSize(long rootId) {
 		try {

logicaldoc-core/src/test/java/com/logicaldoc/core/folder/HibernateFolderDAOTest.java

@@ -184,6 +184,12 @@ public void testCountDocsInTree() throws PersistenceException {
 		assertEquals(0, count);
 	}
 
+	@Test
+	public void testCountDocs() throws PersistenceException {
+		long count = testSubject.countDocs(6L);
+		assertEquals(4, count);
+	}
+	
 	@Test
 	public void testComputeTreeSize() throws PersistenceException {
 		/*

logicaldoc-webapp/src/main/resources/context.properties

@@ -918,4 +918,6 @@ gravatar.enabled = true
 
 onlyoffice.url=
 onlyoffice.security.key=
-onlyoffice.callback=
+onlyoffice.callback=
+
+maxdocsperfolder = 10000

logicaldoc-webapp/src/test/resources/contexttest.properties

@@ -851,4 +851,6 @@ default.anonymous.key=12qwe3gre6k
 default.anonymous.user=anonymous
 
 throttle.username.max = 1
-throttle.username.wait = 30
+throttle.username.wait = 30
+
+maxdocsperfolder = 1000