Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The multiplier point logic is confusing and wrong #51

Closed
3esmit opened this issue Feb 18, 2024 · 1 comment
Closed

The multiplier point logic is confusing and wrong #51

3esmit opened this issue Feb 18, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@3esmit
Copy link
Collaborator

3esmit commented Feb 18, 2024

I am refactoring this logic to be like read like a poem.
Needed for #48

The code is written like math formulas and there is a lot of code duplication.

  • Remove all ` (a == b) ? "case true" : "case false";´ and turn them into a if/else case.
  • Encapsulate the math operations and reuse the same formula whenever is needed
  • Optimize the use of if/elses
@3esmit 3esmit self-assigned this Feb 18, 2024
@3esmit 3esmit linked a pull request Feb 19, 2024 that will close this issue
5 tasks
@0x-r4bbit 0x-r4bbit added the type: bug Something isn't working label Feb 19, 2024
@0x-r4bbit 0x-r4bbit added this to the Staking V1 milestone Feb 19, 2024
@3esmit 3esmit moved this from Todo to In Progress in Tasks - Smart Contracts Feb 19, 2024
@3esmit
Copy link
Collaborator Author

3esmit commented Feb 23, 2024

Done!

@3esmit 3esmit closed this as completed Feb 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tasks - Smart Contracts Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants