Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with pagination #19

Open
Jimmi08 opened this issue Apr 28, 2019 · 1 comment
Open

problem with pagination #19

Jimmi08 opened this issue Apr 28, 2019 · 1 comment

Comments

@Jimmi08
Copy link

Jimmi08 commented Apr 28, 2019

Download category can be paginated.
Default for url (canonical, og:url) is e_SELF

/**
 * Returns with the current URL.
 */
function metatag_global_token_site_current_page_url()
{
	return defset('e_SELF', '');
}

But each page have different url
for example (you got this url when you click on pagination under list)
/download/category/6/stuff-in-development/?order=id&sort=desc&view=3&from=6
is different that
/download/category/6/stuff-in-development/
but e_SELF returns /download/category/6/stuff-in-development/ for all pages.

e_REQUEST_URL would be probably a better idea

@Jimmi08
Copy link
Author

Jimmi08 commented May 9, 2019

@lonalore
Theory:
https://www.stonetemple.com/pagination-canonicalization-seo-your-technical-guide/

I think page number should be part of "entity" - in most case it's 1, only with news and downloads category list could be different (no idea if pages can be paginated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant