feat(v2): DR volume #183
Merged
feat(v2): DR volume #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot if I've implemented the details that are required for v2 DR volume in the go-spdk-helper side. Don't we need to update go-spdk-helper? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
======================================
Coverage 7.86% 7.86%
======================================
Files 23 23
Lines 2010 2010
======================================
Hits 158 158
Misses 1826 1826
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c3y1huang
force-pushed
the
feat-v2-dr-volume
branch
2 times, most recently
from
cb5deaa
to
23f54c1
Compare
c3y1huang
force-pushed
the
feat-v2-dr-volume
branch
3 times, most recently
from
7e34647
to
faad629
Compare
c3y1huang
force-pushed
the
feat-v2-dr-volume
branch
from
faad629
to
9c490fd
Compare
|
It seems good to me but i don't have so much experience on Longhorn backup and restore to understand all the things involved, better to wait for Shuo and Derek to approve. |
c3y1huang
force-pushed
the
feat-v2-dr-volume
branch
3 times, most recently
from
d52fd85
to
ab61bf1
Compare
shuo-wu
previously approved these changes
Aug 23, 2024
A file can be either a regular file for a v1 volume or a device file for a v2 volume. longhorn/longhorn-6613 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-6613 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-v2-dr-volume
branch
from
ab61bf1
to
c0618c6
Compare
derekbit
reviewed
Aug 27, 2024
derekbit
reviewed
Aug 27, 2024
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#6613
What this PR does / why we need it:
Support v2 volume for incremental restore.
Special notes for your reviewer:
NoneAdditional documentation or context
None