revert: fix for fluctuating checksum #188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
feat-v2-dr-volume-fluctuating-checksum
branch
from
23bf686
to
14096a2
Compare
This reverts commit d330ae2. longhorn/longhorn-9305 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-v2-dr-volume-fluctuating-checksum
branch
from
14096a2
to
5cc2e81
Compare
c3y1huang
changed the title
c3y1huang
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
======================================
Coverage 7.86% 7.86%
======================================
Files 23 23
Lines 2010 2010
======================================
Hits 158 158
Misses 1826 1826
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9305
What this PR does / why we need it:
This reverts the commit related to the race condition issue that triggered the fluctuating checksums. We're keeping this PR open for reproduction purposes.
Special notes for your reviewer:
NoneAdditional documentation or context
longhorn/longhorn#6613