From d9d987ba8cf4019af60672b72670dc87034eb4f9 Mon Sep 17 00:00:00 2001 From: Derek Su Date: Tue, 6 Aug 2024 14:33:07 +0800 Subject: [PATCH] fix(replica): best-effort to delete old head disk file The deletion of old head disk file is a best-effort task, and the failure should not hinder the following tasks. Longhorn 9168 Signed-off-by: Derek Su (cherry picked from commit 19d396248aed4a1b0abc3f2e7f0146f3dd58ee41) --- pkg/replica/replica.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/replica/replica.go b/pkg/replica/replica.go index b373df039..09d096308 100644 --- a/pkg/replica/replica.go +++ b/pkg/replica/replica.go @@ -915,8 +915,9 @@ func (r *Replica) createDisk(name string, userCreated bool, created string, labe rollbackFuncList := []func() error{} defer func() { if err == nil { - err = r.rmDisk(oldHead) - logrus.WithError(err).Errorf("Failed to remove old head %v", oldHead) + if errRm := r.rmDisk(oldHead); errRm != nil { + logrus.WithError(errRm).Warnf("Failed to remove old head %v", oldHead) + } return }