Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codespell #1016

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ jobs:
uses: codespell-project/actions-codespell@v2
with:
check_filenames: true
ignore_words_file: .codespellignore
skip: "./proto,*/**.yaml,*/**.yml,./scripts,./vendor,MAINTAINERS,LICENSE,go.mod,go.sum"
skip: "./proto,*/**.yaml,*/**.yml,./scripts,./integration,./vendor,MAINTAINERS,LICENSE,go.mod,go.sum"
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Longhorn Engine implements a lightweight block device storage controller capable
1. The replicas function like a networked disk, supporting read/write operations over a network protocol.
1. The frontend (only Open-iSCSI/tgt are supported at this moment) is a kernel driver that translates read/write operations on the Longhorn block device (mapped at `/dev/longhorn/vol-name`) to user-level network requests on the controller.
1. Each Longhorn block device is backed by its own dedicated controller.
1. The controller sychronously replicates write operations to all replicas.
1. The controller synchronously replicates write operations to all replicas.
1. The controller detects faulty replicas and rebuilds replicas.
1. The controller coordinates snapshot and backup operations.
1. Controllers and replicas are packaged as Docker containers.
Expand Down Expand Up @@ -48,7 +48,7 @@ That will create the device `/dev/longhorn/vol-name`

## Running a controller with multiple replicas

In order to start Longhorn Engine with multiple replicas, you need to setup a network between replica container and controller container. Here we use Docker network feature to demostrate that:
In order to start Longhorn Engine with multiple replicas, you need to setup a network between replica container and controller container. Here we use Docker network feature to demonstrate that:

##### 1. Create a network named `longhorn-net`
```
Expand All @@ -65,7 +65,7 @@ docker run --net longhorn-net --ip 172.18.0.3 -v /volume \
##### 3. Start the controller. Take tgt-blockdev for example:
```
docker run --net longhorn-net --privileged -v /dev:/host/dev -v /proc:/host/proc \
longhornio/longhorn-engine longhorn controller --frontend tgt-blockdev \
longhornio/longhorn-engine longhorn controller --frontend tgt-blockdev \
--replica tcp://172.18.0.2:9502 --replica tcp://172.18.0.3:9502 vol-name
```
Now you will have device `/dev/longhorn/vol-name`.
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/control.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type Controller struct {
// lastExpansionFailedAt indicates if the error belongs to the recent expansion
lastExpansionFailedAt string
// lastExpansionError indicates the error message.
// It may exist even if the expansion succeeded. For exmaple, some of the replica expansions failed.
// It may exist even if the expansion succeeded. For example, some of the replica expansions failed.
lastExpansionError string

fileSyncHTTPClientTimeout int
Expand Down
2 changes: 1 addition & 1 deletion pkg/qcow/libqcow.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (q *Qcow) ReadAt(buf []byte, off int64) (int, error) {
return int(ret), nil
}

func (q *Qcow) UnmapAt(legnth uint32, off int64) (int, error) {
func (q *Qcow) UnmapAt(length uint32, off int64) (int, error) {
return 0, errors.New("Unsupported operation")
}

Expand Down